Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler-rt runtime directory path when -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on #91160

Open
MaskRay opened this issue Nov 23, 2021 · 1 comment
Open

compiler-rt runtime directory path when -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on #91160

MaskRay opened this issue Nov 23, 2021 · 1 comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@MaskRay
Copy link
Contributor

MaskRay commented Nov 23, 2021 •
edited

It seems that "runtimes build" is getting more popular in llvm-project and -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on may possibly be enabled by default in the future.

Currently compiler-rt runtime libraries are aggressive on normalizing the target triple LLVM_DEFAULT_TARGET_TRIPLE=x86_64-linux-gnu to lib/clang/14.0.0/x86_64-unknown-linux-gnu/.

If https://reviews.llvm.org/D109837 (remove config.guess) and https://reviews.llvm.org/D110663 are accepted, the CMake build system will try respecting LLVM_DEFAULT_TARGET_TRIPLE and use lib/clang/14.0.0/x86_64-linux-gnu/.

This is a heads-up in case Rust needs any adjustment. I am not sure it needs, though.
@MaskRay MaskRay changed the title compiler-rt runtime directory path when -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on is enabled compiler-rt runtime directory path when -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on Nov 23, 2021
@jyn514
Copy link
Member

jyn514 commented Apr 9, 2023

Looks like https://reviews.llvm.org/D109837 was merged and https://reviews.llvm.org/D110663 was closed without being merged? Given that CI hasn't broken and no one has complained, does it make sense to close this issue?

@jyn514 jyn514 added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MaskRay @jyn514