Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display ~const Drop in rustdoc #92229

Merged
merged 1 commit into from
Dec 25, 2021

Conversation

fee1-dead
Copy link
Member

Although T: ~const Drop is still at an experimental stage, we have already begun inserting these bounds in libstd. This change hides them from rustdoc because 1. ~const should not be documented in general as it is not yet official syntax; 2. users are not expected to know what ~const Drop means yet.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Dec 23, 2021
@rust-highfive
Copy link
Collaborator

r? @ollie27

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 23, 2021
@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I'd noticed these pop up in the documentation of Option.

@dtolnay
Copy link
Member

dtolnay commented Dec 24, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Dec 24, 2021

📌 Commit 2e8b4a7 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2021
@bors
Copy link
Contributor

bors commented Dec 24, 2021

⌛ Testing commit 2e8b4a7 with merge 83bde52...

@bors
Copy link
Contributor

bors commented Dec 25, 2021

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 83bde52 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 25, 2021
@bors bors merged commit 83bde52 into rust-lang:master Dec 25, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 25, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (83bde52): comparison url.

Summary: This change led to moderate relevant mixed results 🤷 in compiler performance.

  • Moderate improvement in instruction counts (up to -0.8% on incr-unchanged builds of externs)
  • Small regression in instruction counts (up to 1.0% on incr-unchanged builds of deeply-nested-async)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@rustbot rustbot added the perf-regression Performance regression. label Dec 25, 2021
@fee1-dead fee1-dead deleted the fix-rustdoc-const-drop branch December 25, 2021 04:16
@dtolnay dtolnay assigned dtolnay and unassigned ollie27 Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants