New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverts #92135 because perf regression #92291
Reverts #92135 because perf regression #92291
Conversation
I think, we can also try to use |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 72b0c8f with merge d74f38771301649fff720b71840f0d706c349198... |
☀️ Try build successful - checks-actions |
Queued d74f38771301649fff720b71840f0d706c349198 with parent f8abed9, future comparison URL. |
Finished benchmarking commit (d74f38771301649fff720b71840f0d706c349198): comparison url. Summary: This change led to large relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
@bors r+ |
📌 Commit 72b0c8f has been approved by |
JFYI: I wouldn't be able to participate until 15th January. I would return to this PR after that if needed. |
⌛ Testing commit 72b0c8f with merge e3445ee8e3845c62f9a5fc55256e253ee2b60758... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
known flaky test @bors retry |
⌛ Testing commit 72b0c8f with merge 897ab94f9946d6d63f29560f3eec864d04a5968d... |
💔 Test failed - checks-actions |
GHA network(?) failure: @bors retry |
@bors retry |
@AngelicosPhosphoros: 🔑 Insufficient privileges: not in try users |
@bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b70cc64): comparison url. Summary: This change led to large relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Please, start a perf test for this.
r? @joshtriplett You approved original PR.