Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair/improve const eval validation errors #97250

Closed
saethlin opened this issue May 21, 2022 · 1 comment
Closed

Repair/improve const eval validation errors #97250

saethlin opened this issue May 21, 2022 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@saethlin
Copy link
Member

In #95377 I'm proposing that we improve UB detection in const eval by selectively enforcing validity by attempting to detect if unsafe code has been loaded. As a result of this change, programs which would have produced an invalid const item are now detected earlier, and produce a different diagnostic. This new diagnostic doesn't include the memory dump. We should probably add it or something like it back. cc @oli-obk
@saethlin saethlin added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 21, 2022
@saethlin
Copy link
Member Author

Closing because if #95377 or anything like is merged, it will be opt-in.

@saethlin saethlin closed this as not planned Won't fix, can't repro, duplicate, stale Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saethlin