Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap doesn't clone llvm-project if profiling is enabled #99869

Closed
Nilstrieb opened this issue Jul 28, 2022 · 2 comments · Fixed by #99872
Closed

Bootstrap doesn't clone llvm-project if profiling is enabled #99869

Nilstrieb opened this issue Jul 28, 2022 · 2 comments · Fixed by #99872
Assignees
@Nilstrieb
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Nilstrieb
Copy link
Member

Nilstrieb commented Jul 28, 2022 •
edited by rustbot

When using profiler = true in the cargo.toml to enable profiling, having a local copy of src/llvm-project is required. If no such copy is present, errors about missing libraries are emitted and the build fails.

Expected behavior:
Bootstrap initializes the src/llvm-project submodule when profiler is enabled.
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself labels Jul 28, 2022
@jyn514
Copy link
Member

jyn514 commented Jul 28, 2022 •
edited

This should be pretty easy to fix - call builder.update_submodule("src/llvm-project") in impl Step for compile::Std if profiling is enabled.

@jyn514 jyn514 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Jul 28, 2022
@Nilstrieb
Copy link
Member Author

@rustbot claim

@Nilstrieb Nilstrieb mentioned this issue Jul 28, 2022
Merged
@bors bors closed this as completed in a8f77ad Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nilstrieb Nilstrieb

Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clone the src/llvm-project submodule if profiling is enabled Nilstrieb/rust
2 participants
@jyn514 @Nilstrieb