Only specify `--target` by default for `-Zgcc-ld=lld` on wasm #101792

lqd · 2022-09-14T08:41:32Z

On macOS, it's not yet clear which cases of clang/OS/target/SDK version impact how to find ld/lld/rust-lld. The --target argument is not needed on our current targets with a vanilla config to do so, but may be in some cases ?

That is, things look to be different and more subtle than suggested in #97402 (comment).

Specifying this argument unconditionally currently breaks -Zgcc-ld=lld on the 10.7+ targets on x64 macOS. Vanilla configs on x64 and aarch64 don't seem to need it to be able to find rust-lld.

This fixes #101653 on macOS (I've tried on x64 and aarch64: vanilla installs with the most recent command line tools available for each of the OS versions I have access to, run-make/issue-71519 passes).

I didn't expect the previous PRs to fail because of the existing tests, but CI does not actually run those tests yet, which explains the regressions. I was hoping to fix those in this PR but it's more involved (building lld is required for the tests to run, llvm/lld is not built on the test builders but on the dist builders, the dist builders don't run tests). This PR is just to unblock current users on macOS who have reported issues, but a regression could happen in the future by mistake until then.

r? @petrochenkov

tschuett · 2022-09-14T15:34:18Z

Maybe you will need the target on macOS for cross-compiling?

lqd · 2022-09-14T15:53:19Z

It wasn’t used before, so I’m not sure. And you can still pass it via -Clink-arg I presume ?

Wyvern · 2022-09-17T01:23:51Z

Looks like this problem still not fixed.

Another question. Why use -fuse-ld=lld generate clang: error: invalid linker name in argument '-fuse-ld=lld for now?

lqd · 2022-09-17T04:09:40Z

@Wyvern What do you mean not fixed, did you build this PR locally to test ? If so, what error did you get ?

petrochenkov · 2022-09-19T14:34:04Z

10.7 comes from this function in compiler\rustc_target\src\spec\apple_base.rs:

fn macos_default_deployment_target(arch: &str) -> (u32, u32) {
    if arch == "arm64" { (11, 0) } else { (10, 7) }
}

, this is the default version that is used if no MACOSX_DEPLOYMENT_TARGET is provided by the user.

So setting MACOSX_DEPLOYMENT_TARGET that matches your environment should work as a quick workaround for #101653.

UPD: Also this is why the reproduction for x64 and aarch64 is different.

petrochenkov · 2022-09-19T14:44:14Z

@Wyvern

Another question. Why use -fuse-ld=lld generate clang: error: invalid linker name in argument '-fuse-ld=lld for now?

This should only happen if your clang is old (or somehow modified) and doesn't support LLD. In that case it's reasonable that rustc using such clang doesn't support LLD either.

petrochenkov · 2022-09-19T14:48:10Z

So if no MACOSX_DEPLOYMENT_TARGET is specified, then rustc will always pass target x86_64-apple-macosx10.7.0 to LLVM and apparently that's fine for all the range of supported versions.
However, it's apparently not fine to pass it to clang with a different default macosx version.

petrochenkov · 2022-09-19T14:54:36Z

Maybe you will need the target on macOS for cross-compiling?

That's exactly why the --target option is passed, it's not necessary if we are not cross-compiling, clang should find the appropriate lld flavor for the host in that case.

There are several possible cases here:

Not a cross compilation: --target is not necessary, the correct target is either hardcoded or used by default.
Cross compilation:
- Using a separate toolchain for the specific target (gcc is typically used like this), then --target is not necessary because it's hardcoded.
- Using a toolchain that can switch targets dynamically (e.g. usual clang installed on the host), then --target is necessary for that clang to decide what triple to target.

petrochenkov · 2022-09-19T15:03:09Z

I think the initial fix should be

                    if we_are_cross_compiling() {
                        cmd.arg(format!("--target={}", sess.target.llvm_target));
                    }

, so the main question is how to implement the we_are_cross_compiling() part :D

sess.host == sess.target should work in most cases, but I'm not sure it will work for Apple targets specifically due to possible SDK version mismatches between the host and target.

petrochenkov · 2022-09-19T15:26:07Z

so the main question is how to implement the we_are_cross_compiling()

sess.target.lld_flavor != sess.host.lld_flavor!

tschuett · 2022-09-24T16:41:46Z

This could miss the case where I am compiling from OSX to WatchOS. The lld flavour is the same, but I need the target parameter.

we_are_cross_compiling() { there was a target parameter in the rustc invocation. }

petrochenkov · 2022-09-26T10:06:58Z

@tschuett
Sorry, I don't understand.
What do you do in this case when you are compiling without -Zgcc-lld? Exactly the same thing should work with -Zgcc-lld too.

tschuett · 2022-09-26T10:54:27Z

> RUSTFLAGS='-Z gcc-ld=lld' cargo +nightly build --target x86_64-apple-darwin
> RUSTFLAGS='-Z gcc-ld=lld' cargo +nightly build --target x86_64-apple-ios

I am on x86 OSX. The lld flavour is the same, but I would need the target parameter, i.e., the target parameter must be passed to the linker.

petrochenkov · 2022-09-26T21:01:32Z

@tschuett
I guess the current assumption is that you pass it manually (with or without -Z gcc-ld=lld).
Maybe it can be changed for Apple targets specifically, because the compiler there is guaranteed (?) to be clang and accept the --target option, but it's again orthogonal to -Z gcc-ld=lld.

Wyvern · 2022-09-28T04:52:50Z

Is there a plan to merge this PR into nightly build?

lqd · 2022-09-28T21:43:37Z

@Wyvern Yes, we're working on it. Until then, you can also use the MACOSX_DEPLOYMENT_TARGET env var and it'll work. Or a local lld via -Clink-arg=-fuse-ld=lld I guess.

Wyvern · 2022-09-29T05:06:45Z

MACOSX_DEPLOYMENT_TARGET=12.0 works, Thx.

lqd · 2022-12-07T20:49:08Z

@petrochenkov I've rebased over #101988, and added the simili cross-compiling test for macOS, for the possibly different linker flavors between host and targets. Is this now what you expected ?

I've tested this PR on x64 darwin (without cross compilation shenanigans) and -Zgcc-ld will now work. I've also opened a draft PR, waiting on this one, to fix CI so that needs-rust-lld tests will be executed to prevent things from regressing again.

@rustbot ready

compiler/rustc_codegen_ssa/src/back/link.rs

petrochenkov · 2023-01-02T11:11:27Z

Sorry for the delay, I'm currently taking some break from Rust.
@rustbot author

lqd · 2023-01-02T11:37:31Z

Sorry for the delay, I'm currently taking some break from Rust.

@petrochenkov would you rather we re-roll for another reviewer ?

petrochenkov · 2023-01-02T18:49:33Z

@lqd
No, I reassigned most of my PRs so the remaining ones, including this, should be fine.

On macOS, it's not yet clear which cases of clang/OS/target/SDK version impact how to find ld/lld/rust-lld. The --target is not needed on our current targets with a vanilla config, but may be in some cases. Specifying it all the time breaks the 10.7+ targets on x64 macOS. We try to only specify it on macOS if the linker flavors are different, for possible cases of cross-compilation with `-Zgcc-ld=lld` but the expectation is that it should be passed manually when needed in these situations.

lqd · 2023-01-02T23:46:37Z

Removed the superfluous bool.

@rustbot ready

petrochenkov · 2023-01-03T09:55:48Z

@bors r+

bors · 2023-01-03T09:55:50Z

📌 Commit 7770b06 has been approved by petrochenkov

It is now in the queue for this repository.

bors · 2023-01-03T14:05:47Z

⌛ Testing commit 7770b06 with merge 312c9a3...

bors · 2023-01-03T17:08:11Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 312c9a3 to master...

rust-timer · 2023-01-03T19:03:57Z

Finished benchmarking commit (312c9a3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.9%	[2.9%, 2.9%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Ensure `lld` is supported with `download-ci-llvm` This PR: - ensures LLD's step in bootstrap's dist, but it's not strictly necessary since dist will already package it when it's present. - makes bootstrap's `native::LLD` step support using the packaged `ci-llvm/bin/lld`, instead of building it from source (which would most likely not be available today, nor in the future where `download-ci-llvm = if-available` is the default). If I understand correctly, `--enable-full-tools` will also enable `rust.lld`, and this is why LLD is already packaged today in the `rust-dev` component on the main targets (and why `-Zgcc-ld=lld` does work there). That means it's likely that this PR will not be able to land before I've reworked and landed rust-lang#101792: if LLD is available in `download-ci-llvm`, the `needs-rust-lld` tests should start being executed on the x64 macOS test builders, and CI would fail today. I've tested locally that building with `download-ci-llvm = true` and `lld = true` with the LLVM submodule unregistered was successful, and that `rust-lld` and the various `lld-wrapper`s are present and `-Zgcc-ld=lld` works as well, on a few different platforms: - `x86_64-unknown-linux-gnu` - `aarch64-apple-darwin` - `x86_64-pc-windows-msvc` (with `-Clinker=rust-lld` rather than `-Zgcc-ld=lld`) - `x86_64-apple-darwin`, with the `MACOSX_DEPLOYMENT_TARGET` workaround for rust-lang#101653 I don't think we really need to bump the `download-ci-llvm-stamp` in this case, since `./build/$triple/ci-llvm/bin/lld` is present on all the above targets already, but have added it mechanically, and it should probably be removed to avoid unnecessary downloads/churn. Fixes rust-lang#98340 Supersedes rust-lang#100010

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. Upstream changes: Version 1.68.0 (2023-03-09) =========================== Language -------- - [Stabilize default_alloc_error_handler] (rust-lang/rust#102318) This allows usage of `alloc` on stable without requiring the definition of a handler for allocation failure. Defining custom handlers is still unstable. - [Stabilize `efiapi` calling convention.] (rust-lang/rust#105795) - [Remove implicit promotion for types with drop glue] (rust-lang/rust#105085) Compiler -------- - [Change `bindings_with_variant_name` to deny-by-default] (rust-lang/rust#104154) - [Allow .. to be parsed as let initializer] (rust-lang/rust#105701) - [Add `armv7-sony-vita-newlibeabihf` as a tier 3 target] (rust-lang/rust#105712) - [Always check alignment during compile-time const evaluation] (rust-lang/rust#104616) - [Disable "split dwarf inlining" by default.] (rust-lang/rust#106709) - [Add vendor to Fuchsia's target triple] (rust-lang/rust#106429) - [Enable sanitizers for s390x-linux] (rust-lang/rust#107127) Libraries --------- - [Loosen the bound on the Debug implementation of Weak.] (rust-lang/rust#90291) - [Make `std::task::Context` !Send and !Sync] (rust-lang/rust#95985) - [PhantomData layout guarantees] (rust-lang/rust#104081) - [Don't derive Debug for `OnceWith` & `RepeatWith`] (rust-lang/rust#104163) - [Implement DerefMut for PathBuf] (rust-lang/rust#105018) - [Add O(1) `Vec -> VecDeque` conversion guarantee] (rust-lang/rust#105128) - [Leak amplification for peek_mut() to ensure BinaryHeap's invariant is always met] (rust-lang/rust#105851) Stabilized APIs --------------- - [`{core,std}::pin::pin!`] (https://doc.rust-lang.org/stable/std/pin/macro.pin.html) - [`impl From<bool> for {f32,f64}`] (https://doc.rust-lang.org/stable/std/primitive.f32.html#impl-From%3Cbool%3E-for-f32) - [`std::path::MAIN_SEPARATOR_STR`] (https://doc.rust-lang.org/stable/std/path/constant.MAIN_SEPARATOR_STR.html) - [`impl DerefMut for PathBuf`] (https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#impl-DerefMut-for-PathBuf) These APIs are now stable in const contexts: - [`VecDeque::new`] (https://doc.rust-lang.org/stable/std/collections/struct.VecDeque.html#method.new) Cargo ----- - [Stabilize sparse registry support for crates.io] (rust-lang/cargo#11224) - [`cargo build --verbose` tells you more about why it recompiles.] (rust-lang/cargo#11407) - [Show progress of crates.io index update even `net.git-fetch-with-cli` option enabled] (rust-lang/cargo#11579) Misc ---- Compatibility Notes ------------------- - [Add `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` to future-incompat report] (rust-lang/rust#103418) - [Only specify `--target` by default for `-Zgcc-ld=lld` on wasm] (rust-lang/rust#101792) - [Bump `IMPLIED_BOUNDS_ENTAILMENT` to Deny + ReportNow] (rust-lang/rust#106465) - [`std::task::Context` no longer implements Send and Sync] (rust-lang/rust#95985) nternal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Encode spans relative to the enclosing item] (rust-lang/rust#84762) - [Don't normalize in AstConv] (rust-lang/rust#101947) - [Find the right lower bound region in the scenario of partial order relations] (rust-lang/rust#104765) - [Fix impl block in const expr] (rust-lang/rust#104889) - [Check ADT fields for copy implementations considering regions] (rust-lang/rust#105102) - [rustdoc: simplify JS search routine by not messing with lev distance] (rust-lang/rust#105796) - [Enable ThinLTO for rustc on `x86_64-pc-windows-msvc`] (rust-lang/rust#103591) - [Enable ThinLTO for rustc on `x86_64-apple-darwin`] (rust-lang/rust#103647)

Pkgsrc changes: * Adjust patches (add & remove) and cargo checksums to new versions. * It's conceivable that the workaround for LLVM based NetBSD works even less in this version (ref. PKGSRC_HAVE_LIBCPP not having a corresponding patch anymore). Upstream changes: Version 1.68.2 (2023-03-28) =========================== - [Update the GitHub RSA host key bundled within Cargo] (rust-lang/cargo#11883). The key was [rotated by GitHub] (https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/) on 2023-03-24 after the old one leaked. - [Mark the old GitHub RSA host key as revoked] (rust-lang/cargo#11889). This will prevent Cargo from accepting the leaked key even when trusted by the system. - [Add support for `@revoked` and a better error message for `@cert-authority` in Cargo's SSH host key verification] (rust-lang/cargo#11635) Version 1.68.1 (2023-03-23) =========================== - [Fix miscompilation in produced Windows MSVC artifacts] (rust-lang/rust#109094) This was introduced by enabling ThinLTO for the distributed rustc which led to miscompilations in the resulting binary. Currently this is believed to be limited to the -Zdylib-lto flag used for rustc compilation, rather than a general bug in ThinLTO, so only rustc artifacts should be affected. - [Fix --enable-local-rust builds] (rust-lang/rust#109111) - [Treat `$prefix-clang` as `clang` in linker detection code] (rust-lang/rust#109156) - [Fix panic in compiler code] (rust-lang/rust#108162) Version 1.68.0 (2023-03-09) =========================== Language -------- - [Stabilize default_alloc_error_handler] (rust-lang/rust#102318) This allows usage of `alloc` on stable without requiring the definition of a handler for allocation failure. Defining custom handlers is still unstable. - [Stabilize `efiapi` calling convention.] (rust-lang/rust#105795) - [Remove implicit promotion for types with drop glue] (rust-lang/rust#105085) Compiler -------- - [Change `bindings_with_variant_name` to deny-by-default] (rust-lang/rust#104154) - [Allow .. to be parsed as let initializer] (rust-lang/rust#105701) - [Add `armv7-sony-vita-newlibeabihf` as a tier 3 target] (rust-lang/rust#105712) - [Always check alignment during compile-time const evaluation] (rust-lang/rust#104616) - [Disable "split dwarf inlining" by default.] (rust-lang/rust#106709) - [Add vendor to Fuchsia's target triple] (rust-lang/rust#106429) - [Enable sanitizers for s390x-linux] (rust-lang/rust#107127) Libraries --------- - [Loosen the bound on the Debug implementation of Weak.] (rust-lang/rust#90291) - [Make `std::task::Context` !Send and !Sync] (rust-lang/rust#95985) - [PhantomData layout guarantees] (rust-lang/rust#104081) - [Don't derive Debug for `OnceWith` & `RepeatWith`] (rust-lang/rust#104163) - [Implement DerefMut for PathBuf] (rust-lang/rust#105018) - [Add O(1) `Vec -> VecDeque` conversion guarantee] (rust-lang/rust#105128) - [Leak amplification for peek_mut() to ensure BinaryHeap's invariant is always met] (rust-lang/rust#105851) Stabilized APIs --------------- - [`{core,std}::pin::pin!`] (https://doc.rust-lang.org/stable/std/pin/macro.pin.html) - [`impl From<bool> for {f32,f64}`] (https://doc.rust-lang.org/stable/std/primitive.f32.html#impl-From%3Cbool%3E-for-f32) - [`std::path::MAIN_SEPARATOR_STR`] (https://doc.rust-lang.org/stable/std/path/constant.MAIN_SEPARATOR_STR.html) - [`impl DerefMut for PathBuf`] (https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#impl-DerefMut-for-PathBuf) These APIs are now stable in const contexts: - [`VecDeque::new`] (https://doc.rust-lang.org/stable/std/collections/struct.VecDeque.html#method.new) Cargo ----- - [Stabilize sparse registry support for crates.io] (rust-lang/cargo#11224) - [`cargo build --verbose` tells you more about why it recompiles.] (rust-lang/cargo#11407) - [Show progress of crates.io index update even `net.git-fetch-with-cli` option enabled] (rust-lang/cargo#11579) Misc ---- Compatibility Notes ------------------- - [Add `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` to future-incompat report] (rust-lang/rust#103418) - [Only specify `--target` by default for `-Zgcc-ld=lld` on wasm] (rust-lang/rust#101792) - [Bump `IMPLIED_BOUNDS_ENTAILMENT` to Deny + ReportNow] (rust-lang/rust#106465) - [`std::task::Context` no longer implements Send and Sync] (rust-lang/rust#95985) nternal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Encode spans relative to the enclosing item] (rust-lang/rust#84762) - [Don't normalize in AstConv] (rust-lang/rust#101947) - [Find the right lower bound region in the scenario of partial order relations] (rust-lang/rust#104765) - [Fix impl block in const expr] (rust-lang/rust#104889) - [Check ADT fields for copy implementations considering regions] (rust-lang/rust#105102) - [rustdoc: simplify JS search routine by not messing with lev distance] (rust-lang/rust#105796) - [Enable ThinLTO for rustc on `x86_64-pc-windows-msvc`] (rust-lang/rust#103591) - [Enable ThinLTO for rustc on `x86_64-apple-darwin`] (rust-lang/rust#103647) Version 1.67.0 (2023-01-26) ========================== Language -------- - [Make `Sized` predicates coinductive, allowing cycles.] (rust-lang/rust#100386) - [`#[must_use]` annotations on `async fn` also affect the `Future::Output`.] (rust-lang/rust#100633) - [Elaborate supertrait obligations when deducing closure signatures.] (rust-lang/rust#101834) - [Invalid literals are no longer an error under `cfg(FALSE)`.] (rust-lang/rust#102944) - [Unreserve braced enum variants in value namespace.] (rust-lang/rust#103578) Compiler -------- - [Enable varargs support for calling conventions other than `C` or `cdecl`.] (rust-lang/rust#97971) - [Add new MIR constant propagation based on dataflow analysis.] (rust-lang/rust#101168) - [Optimize field ordering by grouping m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) - [Stabilize native library modifier `verbatim`.] (rust-lang/rust#104360) Added and removed targets: - [Add a tier 3 target for PowerPC on AIX] (rust-lang/rust#102293), `powerpc64-ibm-aix`. - [Add a tier 3 target for the Sony PlayStation 1] (rust-lang/rust#102689), `mipsel-sony-psx`. - [Add tier 3 `no_std` targets for the QNX Neutrino RTOS] (rust-lang/rust#102701), `aarch64-unknown-nto-qnx710` and `x86_64-pc-nto-qnx710`. - [Remove tier 3 `linuxkernel` targets] (rust-lang/rust#104015) (not used by the actual kernel). Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Merge `crossbeam-channel` into `std::sync::mpsc`.] (rust-lang/rust#93563) - [Fix inconsistent rounding of 0.5 when formatted to 0 decimal places.] (rust-lang/rust#102935) - [Derive `Eq` and `Hash` for `ControlFlow`.] (rust-lang/rust#103084) - [Don't build `compiler_builtins` with `-C panic=abort`.] (rust-lang/rust#103786) Stabilized APIs --------------- - [`{integer}::checked_ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog) - [`{integer}::checked_ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog2) - [`{integer}::checked_ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog10) - [`{integer}::ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog) - [`{integer}::ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog2) - [`{integer}::ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog10) - [`NonZeroU*::ilog2`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog2) - [`NonZeroU*::ilog10`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog10) - [`NonZero*::BITS`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#associatedconstant.BITS) These APIs are now stable in const contexts: - [`char::from_u32`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_u32) - [`char::from_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_digit) - [`char::to_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_digit) - [`core::char::from_u32`] (https://doc.rust-lang.org/stable/core/char/fn.from_u32.html) - [`core::char::from_digit`] (https://doc.rust-lang.org/stable/core/char/fn.from_digit.html) Compatibility Notes ------------------- - [The layout of `repr(Rust)` types now groups m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) This is intended to be an optimization, but it is also known to increase type sizes in a few cases for the placement of enum tags. As a reminder, the layout of `repr(Rust)` types is an implementation detail, subject to change. - [0.5 now rounds to 0 when formatted to 0 decimal places.] (rust-lang/rust#102935) This makes it consistent with the rest of floating point formatting that rounds ties toward even digits. - [Chains of `&&` and `||` will now drop temporaries from their sub-expressions in evaluation order, left-to-right.] (rust-lang/rust#103293) Previously, it was "twisted" such that the _first_ expression dropped its temporaries _last_, after all of the other expressions dropped in order. - [Underscore suffixes on string literals are now a hard error.] (rust-lang/rust#103914) This has been a future-compatibility warning since 1.20.0. - [Stop passing `-export-dynamic` to `wasm-ld`.] (rust-lang/rust#105405) - [`main` is now mangled as `__main_void` on `wasm32-wasi`.] (rust-lang/rust#105468) - [Cargo now emits an error if there are multiple registries in the configuration with the same index URL.] (rust-lang/cargo#10592) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Rewrite LLVM's archive writer in Rust.] (rust-lang/rust#97485)

rust-highfive assigned petrochenkov Sep 14, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 14, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2022

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2022

This comment was marked as resolved.

Sign in to view

lqd mentioned this pull request Nov 23, 2022

Ensure lld is supported with download-ci-llvm #104748

Merged

lqd force-pushed the rust-lld branch from faf967e to c8440d8 Compare December 7, 2022 18:48

lqd changed the title ~~Only specify --target for -Zgcc-ld=lld on wasm~~ Only specify --target by default for -Zgcc-ld=lld on wasm Dec 7, 2022

lqd force-pushed the rust-lld branch from c8440d8 to 25e0c4e Compare December 7, 2022 20:48

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 7, 2022

petrochenkov reviewed Jan 2, 2023

View reviewed changes

compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2023

lqd force-pushed the rust-lld branch from 25e0c4e to 7770b06 Compare January 2, 2023 23:40

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 2, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 3, 2023

bors merged commit 312c9a3 into rust-lang:master Jan 3, 2023

rustbot added this to the 1.68.0 milestone Jan 3, 2023

lqd deleted the rust-lld branch January 3, 2023 17:30

petrochenkov mentioned this pull request Jan 18, 2024

[WIP] Linker flavors: next steps #119906

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only specify `--target` by default for `-Zgcc-ld=lld` on wasm #101792

Only specify `--target` by default for `-Zgcc-ld=lld` on wasm #101792

lqd commented Sep 14, 2022

tschuett commented Sep 14, 2022

lqd commented Sep 14, 2022

Wyvern commented Sep 17, 2022

lqd commented Sep 17, 2022

petrochenkov commented Sep 19, 2022 •

edited

petrochenkov commented Sep 19, 2022

petrochenkov commented Sep 19, 2022

petrochenkov commented Sep 19, 2022

petrochenkov commented Sep 19, 2022

petrochenkov commented Sep 19, 2022

tschuett commented Sep 24, 2022 •

edited

petrochenkov commented Sep 26, 2022

tschuett commented Sep 26, 2022 •

edited

petrochenkov commented Sep 26, 2022

Wyvern commented Sep 28, 2022

lqd commented Sep 28, 2022

Wyvern commented Sep 29, 2022

This comment was marked as resolved.

lqd commented Dec 7, 2022

petrochenkov commented Jan 2, 2023

lqd commented Jan 2, 2023

petrochenkov commented Jan 2, 2023

lqd commented Jan 2, 2023

petrochenkov commented Jan 3, 2023

bors commented Jan 3, 2023

bors commented Jan 3, 2023

bors commented Jan 3, 2023

rust-timer commented Jan 3, 2023

Only specify --target by default for -Zgcc-ld=lld on wasm #101792

Only specify --target by default for -Zgcc-ld=lld on wasm #101792

Conversation

lqd commented Sep 14, 2022

tschuett commented Sep 14, 2022

lqd commented Sep 14, 2022

Wyvern commented Sep 17, 2022

lqd commented Sep 17, 2022

petrochenkov commented Sep 19, 2022 • edited

petrochenkov commented Sep 19, 2022

petrochenkov commented Sep 19, 2022

petrochenkov commented Sep 19, 2022

petrochenkov commented Sep 19, 2022

petrochenkov commented Sep 19, 2022

tschuett commented Sep 24, 2022 • edited

petrochenkov commented Sep 26, 2022

tschuett commented Sep 26, 2022 • edited

petrochenkov commented Sep 26, 2022

Wyvern commented Sep 28, 2022

lqd commented Sep 28, 2022

Wyvern commented Sep 29, 2022

This comment was marked as resolved.

lqd commented Dec 7, 2022

petrochenkov commented Jan 2, 2023

lqd commented Jan 2, 2023

petrochenkov commented Jan 2, 2023

lqd commented Jan 2, 2023

petrochenkov commented Jan 3, 2023

bors commented Jan 3, 2023

bors commented Jan 3, 2023

bors commented Jan 3, 2023

rust-timer commented Jan 3, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Only specify `--target` by default for `-Zgcc-ld=lld` on wasm #101792

Only specify `--target` by default for `-Zgcc-ld=lld` on wasm #101792

petrochenkov commented Sep 19, 2022 •

edited

tschuett commented Sep 24, 2022 •

edited

tschuett commented Sep 26, 2022 •

edited