Add a builtin `FnPtr` trait that is implemented for all function pointers #108080

oli-obk · 2023-02-15T12:46:08Z

Rebased version of #99531 (plus adjustments mentioned in the PR).

If perf is happy with this version, I would like to land it, even if the diagnostics fix in 9df8e1befb5031a5bf9d8dfe25170620642d3c59 only works for FnPtr specifically, and does not generally improve blanket impls.

rustbot · 2023-02-15T12:46:13Z

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

oli-obk · 2023-02-15T12:46:19Z

@bors try @rust-timer queue

bors · 2023-02-15T12:46:29Z

⌛ Trying commit 9df8e1befb5031a5bf9d8dfe25170620642d3c59 with merge 5913ce478adab3c09b8724a063a0f7e6ec8488e6...

lcnr · 2023-02-15T13:29:43Z

compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs

+                obligation.param_env,
+                self.tcx().mk_predicate(obligation.predicate.map_bound(|obl_pred| {
+                    ty::EarlyBinder(predicate.kind().no_bound_vars().unwrap())
+                        .subst(self.tcx(), obl_pred.trait_ref.substs)


these substs are wrong. You would need to use the impl_substs (returned by match_impl) here instead of the trait substs:

trait Foo {} impl<T> Foo for Vec<T> where T: FnPtr, {}

if you now had Vec<fn()>: Foo we would look at the impl, call substs on T: FnPtr with the substs from the trait, which are Vec<fn()> instead of the impl substs which would be fn().

lcnr · 2023-02-15T13:42:52Z

compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs

@@ -365,14 +366,54 @@ impl<'cx, 'tcx> SelectionContext<'cx, 'tcx> {
                }

                self.infcx.probe(|_| {
-                    if let Ok(_substs) = self.match_impl(impl_def_id, impl_trait_ref, obligation) {
+                    if let Ok(_) = self.match_impl(impl_def_id, impl_trait_ref, obligation) {
+                        if self.reject_fn_ptr_impls(impl_def_id, obligation) {


r=me on the general approach if perf is acceptable. Only need an FCP 😅 it kinda sucks that this kinda requires approval from all of types, lang, and libs 😅

I would prefer us to make it clear that this a hack only for perf and diagnostics, please add a comment here and rename the function to fast_reject_x 😁

I had it called fast_.. first, but considered that invoking evaluate_obligation isn't really fast 😆

lcnr · 2023-02-15T13:46:31Z

compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs

+            if self.tcx().lang_items().fn_ptr_trait() != Some(pred.trait_ref.def_id) {
+                continue;
+            }
+            match pred.self_ty().kind() {


my idea for the check here would be slightly different:

subst the self_ty using the impl_substs, if it is not an FnPtr or infer var, walk the param_env and reject eagerly here if no whatever: FnPtr predicate exists.

bors · 2023-02-15T14:57:22Z

☀️ Try build successful - checks-actions
Build commit: 5913ce478adab3c09b8724a063a0f7e6ec8488e6 (5913ce478adab3c09b8724a063a0f7e6ec8488e6)

rust-timer · 2023-02-15T16:14:26Z

Finished benchmarking commit (5913ce478adab3c09b8724a063a0f7e6ec8488e6): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[1.0%, 5.1%]	10
Regressions ❌ (secondary)	1.3%	[1.1%, 1.6%]	7
Improvements ✅ (primary)	-1.5%	[-7.7%, -0.2%]	21
Improvements ✅ (secondary)	-4.2%	[-7.4%, -0.5%]	27
All ❌✅ (primary)	-0.0%	[-7.7%, 5.1%]	31

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[2.3%, 4.1%]	4
Improvements ✅ (primary)	-2.5%	[-3.9%, -0.8%]	25
Improvements ✅ (secondary)	-2.9%	[-6.1%, -0.9%]	165
All ❌✅ (primary)	-2.5%	[-3.9%, -0.8%]	25

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[2.9%, 4.4%]	6
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-4.4%	[-8.1%, -2.6%]	7
Improvements ✅ (secondary)	-6.3%	[-8.1%, -2.2%]	19
All ❌✅ (primary)	-0.8%	[-8.1%, 4.4%]	13

lcnr · 2023-02-15T16:46:46Z

probably have to fast reject before the match_impl 🤔 that means we don't have the impl substs available. Probably want to have a quick check for impls with self ty ty::Param and self_ty: FnPtr bound instead, because that one doesn#t need to match the impl header

compiler/rustc_trait_selection/src/solve/trait_goals.rs

est31 · 2023-03-06T05:02:29Z

This has instantly-stable impact, right? As in, traits like Ord being implemented on not just fn pointers with up to 16 arguments but for fn pointers with all numbers of arguments.

oli-obk · 2023-03-06T16:54:18Z

@bors try @rust-timer queue

bors · 2023-03-06T16:54:30Z

⌛ Trying commit f253bd3d3edfed399370241ee427bb50de090be1 with merge bbe2a8d23cac6dccb13b34aa39e912f0a5559912...

bors · 2023-03-06T19:01:44Z

☀️ Try build successful - checks-actions
Build commit: bbe2a8d23cac6dccb13b34aa39e912f0a5559912 (bbe2a8d23cac6dccb13b34aa39e912f0a5559912)

bors · 2023-03-06T19:01:44Z

☀️ Try build successful - checks-actions
Build commit: bbe2a8d23cac6dccb13b34aa39e912f0a5559912 (bbe2a8d23cac6dccb13b34aa39e912f0a5559912)

bors · 2023-03-28T15:18:01Z

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing bf57e8a to master...

rust-timer · 2023-03-28T18:30:23Z

Finished benchmarking commit (bf57e8a): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.2%	[1.1%, 5.5%]	10
Regressions ❌ (secondary)	0.9%	[0.3%, 1.1%]	5
Improvements ✅ (primary)	-1.8%	[-7.3%, -0.3%]	17
Improvements ✅ (secondary)	-4.0%	[-7.5%, -0.4%]	27
All ❌✅ (primary)	0.1%	[-7.3%, 5.5%]	27

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.0%	[4.0%, 4.0%]	1
Improvements ✅ (primary)	-2.4%	[-5.2%, -0.7%]	27
Improvements ✅ (secondary)	-3.4%	[-5.5%, -2.0%]	26
All ❌✅ (primary)	-2.4%	[-5.2%, -0.7%]	27

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[2.6%, 4.1%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.0%	[-8.5%, -1.4%]	10
Improvements ✅ (secondary)	-6.8%	[-8.6%, -3.1%]	19
All ❌✅ (primary)	-1.3%	[-8.5%, 4.1%]	16

oli-obk · 2023-03-28T18:35:38Z

specialization_graph_of got more expensive due to the new blanket impls. I'll look into that

Update the toolchain to use nightly-2023-04-16. Changes were related to the following changes to the toolchain: - rust-lang/rust#108944 - rust-lang/rust#108148 - rust-lang/rust#108471 - rust-lang/rust#109358 - rust-lang/rust#109849 - rust-lang/rust#109819 - rust-lang/rust#109718 - rust-lang/rust#109092 - rust-lang/rust#108856 - rust-lang/rust#105613 - rust-lang/rust#103042 - rust-lang/rust#109716 - rust-lang/rust#108340 - rust-lang/rust#102906 - rust-lang/rust#98112 - rust-lang/rust#108080

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. * Adjust to not cross-build to 8.0, due to LLVM using c++17, so adjust USE_LANGUAGES. Upstream changes: Version 1.70.0 (2023-06-01) ========================== Language -------- - [Relax ordering rules for `asm!` operands] (rust-lang/rust#105798) - [Properly allow macro expanded `format_args` invocations to uses captures] (rust-lang/rust#106505) - [Lint ambiguous glob re-exports] (rust-lang/rust#107880) - [Perform const and unsafe checking for expressions in `let _ = expr` position.] (rust-lang/rust#102256) Compiler -------- - [Extend -Cdebuginfo with new options and named aliases] (rust-lang/rust#109808) This provides a smaller version of debuginfo for cases that only need line number information (`-Cdebuginfo=line-tables-only`), which may eventually become the default for `-Cdebuginfo=1`. - [Make `unused_allocation` lint against `Box::new` too] (rust-lang/rust#104363) - [Detect uninhabited types early in const eval] (rust-lang/rust#109435) - [Switch to LLD as default linker for {arm,thumb}v4t-none-eabi] (rust-lang/rust#109721) - [Add tier 3 target `loongarch64-unknown-linux-gnu`] (rust-lang/rust#96971) - [Add tier 3 target for `i586-pc-nto-qnx700` (QNX Neutrino RTOS, version 7.0)] (rust-lang/rust#109173), - [Insert alignment checks for pointer dereferences as debug assertions] (rust-lang/rust#98112) This catches undefined behavior at runtime, and may cause existing code to fail. Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Document NonZeroXxx layout guarantees] (rust-lang/rust#94786) - [Windows: make `Command` prefer non-verbatim paths] (rust-lang/rust#96391) - [Implement Default for some alloc/core iterators] (rust-lang/rust#99929) - [Fix handling of trailing bare CR in str::lines] (rust-lang/rust#100311) - [allow negative numeric literals in `concat!`] (rust-lang/rust#106844) - [Add documentation about the memory layout of `Cell`] (rust-lang/rust#106921) - [Use `partial_cmp` to implement tuple `lt`/`le`/`ge`/`gt`] (rust-lang/rust#108157) - [Stabilize `atomic_as_ptr`] (rust-lang/rust#108419) - [Stabilize `nonnull_slice_from_raw_parts`] (rust-lang/rust#97506) - [Partial stabilization of `once_cell`] (rust-lang/rust#105587) - [Stabilize `nonzero_min_max`] (rust-lang/rust#106633) - [Flatten/inline format_args!() and (string and int) literal arguments into format_args!()] (rust-lang/rust#106824) - [Stabilize movbe target feature] (rust-lang/rust#107711) - [don't splice from files into pipes in io::copy] (rust-lang/rust#108283) - [Add a builtin unstable `FnPtr` trait that is implemented for all function pointers] (rust-lang/rust#108080) This extends `Debug`, `Pointer`, `Hash`, `PartialEq`, `Eq`, `PartialOrd`, and `Ord` implementations for function pointers with all ABIs. Stabilized APIs --------------- - [`NonZero*::MIN/MAX`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroI8.html#associatedconstant.MIN) - [`BinaryHeap::retain`] (https://doc.rust-lang.org/stable/std/collections/struct.BinaryHeap.html#method.retain) - [`Default for std::collections::binary_heap::IntoIter`] (https://doc.rust-lang.org/stable/std/collections/binary_heap/struct.IntoIter.html) - [`Default for std::collections::btree_map::{IntoIter, Iter, IterMut}`] (https://doc.rust-lang.org/stable/std/collections/btree_map/struct.IntoIter.html) - [`Default for std::collections::btree_map::{IntoKeys, Keys}`] (https://doc.rust-lang.org/stable/std/collections/btree_map/struct.IntoKeys.html) - [`Default for std::collections::btree_map::{IntoValues, Values}`] (https://doc.rust-lang.org/stable/std/collections/btree_map/struct.IntoKeys.html) - [`Default for std::collections::btree_map::Range`] (https://doc.rust-lang.org/stable/std/collections/btree_map/struct.Range.html) - [`Default for std::collections::btree_set::{IntoIter, Iter}`] (https://doc.rust-lang.org/stable/std/collections/btree_set/struct.IntoIter.html) - [`Default for std::collections::btree_set::Range`] (https://doc.rust-lang.org/stable/std/collections/btree_set/struct.Range.html) - [`Default for std::collections::linked_list::{IntoIter, Iter, IterMut}`] (https://doc.rust-lang.org/stable/alloc/collections/linked_list/struct.IntoIter.html) - [`Default for std::vec::IntoIter`] (https://doc.rust-lang.org/stable/alloc/vec/struct.IntoIter.html#impl-Default-for-IntoIter%3CT,+A%3E) - [`Default for std::iter::Chain`] (https://doc.rust-lang.org/stable/std/iter/struct.Chain.html) - [`Default for std::iter::Cloned`] (https://doc.rust-lang.org/stable/std/iter/struct.Cloned.html) - [`Default for std::iter::Copied`] (https://doc.rust-lang.org/stable/std/iter/struct.Copied.html) - [`Default for std::iter::Enumerate`] (https://doc.rust-lang.org/stable/std/iter/struct.Enumerate.html) - [`Default for std::iter::Flatten`] (https://doc.rust-lang.org/stable/std/iter/struct.Flatten.html) - [`Default for std::iter::Fuse`] (https://doc.rust-lang.org/stable/std/iter/struct.Fuse.html) - [`Default for std::iter::Rev`] (https://doc.rust-lang.org/stable/std/iter/struct.Rev.html) - [`Default for std::slice::Iter`] (https://doc.rust-lang.org/stable/std/slice/struct.Iter.html) - [`Default for std::slice::IterMut`] (https://doc.rust-lang.org/stable/std/slice/struct.IterMut.html) - [`Rc::into_inner`] (https://doc.rust-lang.org/stable/alloc/rc/struct.Rc.html#method.into_inner) - [`Arc::into_inner`] (https://doc.rust-lang.org/stable/alloc/sync/struct.Arc.html#method.into_inner) - [`std::cell::OnceCell`] (https://doc.rust-lang.org/stable/std/cell/struct.OnceCell.html) - [`Option::is_some_and`] (https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.is_some_and) - [`NonNull::slice_from_raw_parts`] (https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.slice_from_raw_parts) - [`Result::is_ok_and`] (https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.is_ok_and) - [`Result::is_err_and`] (https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.is_err_and) - [`std::sync::atomic::Atomic*::as_ptr`] (https://doc.rust-lang.org/stable/std/sync/atomic/struct.AtomicU8.html#method.as_ptr) - [`std::io::IsTerminal`] (https://doc.rust-lang.org/stable/std/io/trait.IsTerminal.html) - [`std::os::linux::net::SocketAddrExt`] (https://doc.rust-lang.org/stable/std/os/linux/net/trait.SocketAddrExt.html) - [`std::os::unix::net::UnixDatagram::bind_addr`] (https://doc.rust-lang.org/stable/std/os/unix/net/struct.UnixDatagram.html#method.bind_addr) - [`std::os::unix::net::UnixDatagram::connect_addr`] (https://doc.rust-lang.org/stable/std/os/unix/net/struct.UnixDatagram.html#method.connect_addr) - [`std::os::unix::net::UnixDatagram::send_to_addr`] (https://doc.rust-lang.org/stable/std/os/unix/net/struct.UnixDatagram.html#method.send_to_addr) - [`std::os::unix::net::UnixListener::bind_addr`] (https://doc.rust-lang.org/stable/std/os/unix/net/struct.UnixListener.html#method.bind_addr) - [`std::path::Path::as_mut_os_str`] (https://doc.rust-lang.org/stable/std/path/struct.Path.html#method.as_mut_os_str) - [`std::sync::OnceLock`] (https://doc.rust-lang.org/stable/std/sync/struct.OnceLock.html) Cargo ----- - [Add `CARGO_PKG_README`] (rust-lang/cargo#11645) - [Make `sparse` the default protocol for crates.io] (rust-lang/cargo#11791) - [Accurately show status when downgrading dependencies] (rust-lang/cargo#11839) - [Use registry.default for login/logout] (rust-lang/cargo#11949) - [Stabilize `cargo logout`] (rust-lang/cargo#11950) Misc ---- - [Stabilize rustdoc `--test-run-directory`] (rust-lang/rust#103682) Compatibility Notes ------------------- - [Prevent stable `libtest` from supporting `-Zunstable-options`] (rust-lang/rust#109044) - [Perform const and unsafe checking for expressions in `let _ = expr` position.] (rust-lang/rust#102256) - [WebAssembly targets enable `sign-ext` and `mutable-globals` features in codegen] (rust-lang/rust#109807) This may cause incompatibility with older execution environments. - [Insert alignment checks for pointer dereferences as debug assertions] (rust-lang/rust#98112) This catches undefined behavior at runtime, and may cause existing code to fail. Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Upgrade to LLVM 16] (rust-lang/rust#109474) - [Use SipHash-1-3 instead of SipHash-2-4 for StableHasher] (rust-lang/rust#107925)

Support `FnPtr` trait This PR implements support for `FnPtr` trait added by rust-lang/rust#108080. Since that PR also changed some trait impls for function pointer types in core to make use of `FnPtr`, rust-analyzer needs this to adapt to them. Unlike other built-in traits, I didn't add a new mod specifically for `FnPtr`, because we only need to check if the type is a `TyKind::Function` and nothing else.

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. * Add support for NetBSD/riscv64. Upstream changes: Version 1.70.0 (2023-06-01) ========================== Language -------- - [Relax ordering rules for `asm!` operands] (rust-lang/rust#105798) - [Properly allow macro expanded `format_args` invocations to uses captures] (rust-lang/rust#106505) - [Lint ambiguous glob re-exports] (rust-lang/rust#107880) - [Perform const and unsafe checking for expressions in `let _ = expr` position.] (rust-lang/rust#102256) Compiler -------- - [Extend -Cdebuginfo with new options and named aliases] (rust-lang/rust#109808) This provides a smaller version of debuginfo for cases that only need line number information (`-Cdebuginfo=line-tables-only`), which may eventually become the default for `-Cdebuginfo=1`. - [Make `unused_allocation` lint against `Box::new` too] (rust-lang/rust#104363) - [Detect uninhabited types early in const eval] (rust-lang/rust#109435) - [Switch to LLD as default linker for {arm,thumb}v4t-none-eabi] (rust-lang/rust#109721) - [Add tier 3 target `loongarch64-unknown-linux-gnu`] (rust-lang/rust#96971) - [Add tier 3 target for `i586-pc-nto-qnx700`(QNX Neutrino RTOS, version 7.0)] (rust-lang/rust#109173), - [Insert alignment checks for pointer dereferences as debug assertions] (rust-lang/rust#98112) This catches undefined behavior at runtime, and may cause existing code to fail. Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Document NonZeroXxx layout guarantees] (rust-lang/rust#94786) - [Windows: make `Command` prefer non-verbatim paths] (rust-lang/rust#96391) - [Implement Default for some alloc/core iterators] (rust-lang/rust#99929) - [Fix handling of trailing bare CR in str::lines] (rust-lang/rust#100311) - [allow negative numeric literals in `concat!`] (rust-lang/rust#106844) - [Add documentation about the memory layout of `Cell`] (rust-lang/rust#106921) - [Use `partial_cmp` to implement tuple `lt`/`le`/`ge`/`gt`] (rust-lang/rust#108157) - [Stabilize `atomic_as_ptr`] (rust-lang/rust#108419) - [Stabilize `nonnull_slice_from_raw_parts`] (rust-lang/rust#97506) - [Partial stabilization of `once_cell`] (rust-lang/rust#105587) - [Stabilize `nonzero_min_max`] (rust-lang/rust#106633) - [Flatten/inline format_args!() and (string and int) literal arguments into format_args!()] (rust-lang/rust#106824) - [Stabilize movbe target feature] (rust-lang/rust#107711) - [don't splice from files into pipes in io::copy] (rust-lang/rust#108283) - [Add a builtin unstable `FnPtr` trait that is implemented for all function pointers] (rust-lang/rust#108080) This extends `Debug`, `Pointer`, `Hash`, `PartialEq`, `Eq`, `PartialOrd`, and `Ord` implementations for function pointers with all ABIs. Stabilized APIs --------------- - [`NonZero*::MIN/MAX`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroI8.html#associatedconstant.MIN) - [`BinaryHeap::retain`] (https://doc.rust-lang.org/stable/std/collections/struct.BinaryHeap.html#method.retain) - [`Default for std::collections::binary_heap::IntoIter`] (https://doc.rust-lang.org/stable/std/collections/binary_heap/struct.IntoIter.html) - [`Default for std::collections::btree_map::{IntoIter, Iter, IterMut}`] (https://doc.rust-lang.org/stable/std/collections/btree_map/struct.IntoIter.html) - [`Default for std::collections::btree_map::{IntoKeys, Keys}`] (https://doc.rust-lang.org/stable/std/collections/btree_map/struct.IntoKeys.html) - [`Default for std::collections::btree_map::{IntoValues, Values}`] (https://doc.rust-lang.org/stable/std/collections/btree_map/struct.IntoKeys.html) - [`Default for std::collections::btree_map::Range`] (https://doc.rust-lang.org/stable/std/collections/btree_map/struct.Range.html) - [`Default for std::collections::btree_set::{IntoIter, Iter}`] (https://doc.rust-lang.org/stable/std/collections/btree_set/struct.IntoIter.html) - [`Default for std::collections::btree_set::Range`] (https://doc.rust-lang.org/stable/std/collections/btree_set/struct.Range.html) - [`Default for std::collections::linked_list::{IntoIter, Iter, IterMut}`] (https://doc.rust-lang.org/stable/alloc/collections/linked_list/struct.IntoIter.html) - [`Default for std::vec::IntoIter`] (https://doc.rust-lang.org/stable/alloc/vec/struct.IntoIter.html#impl-Default-for-IntoIter%3CT,+A%3E) - [`Default for std::iter::Chain`] (https://doc.rust-lang.org/stable/std/iter/struct.Chain.html) - [`Default for std::iter::Cloned`] (https://doc.rust-lang.org/stable/std/iter/struct.Cloned.html) - [`Default for std::iter::Copied`] (https://doc.rust-lang.org/stable/std/iter/struct.Copied.html) - [`Default for std::iter::Enumerate`] (https://doc.rust-lang.org/stable/std/iter/struct.Enumerate.html) - [`Default for std::iter::Flatten`] (https://doc.rust-lang.org/stable/std/iter/struct.Flatten.html) - [`Default for std::iter::Fuse`] (https://doc.rust-lang.org/stable/std/iter/struct.Fuse.html) - [`Default for std::iter::Rev`] (https://doc.rust-lang.org/stable/std/iter/struct.Rev.html) - [`Default for std::slice::Iter`] (https://doc.rust-lang.org/stable/std/slice/struct.Iter.html) - [`Default for std::slice::IterMut`] (https://doc.rust-lang.org/stable/std/slice/struct.IterMut.html) - [`Rc::into_inner`] (https://doc.rust-lang.org/stable/alloc/rc/struct.Rc.html#method.into_inner) - [`Arc::into_inner`] (https://doc.rust-lang.org/stable/alloc/sync/struct.Arc.html#method.into_inner) - [`std::cell::OnceCell`] (https://doc.rust-lang.org/stable/std/cell/struct.OnceCell.html) - [`Option::is_some_and`] (https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.is_some_and) - [`NonNull::slice_from_raw_parts`] (https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.slice_from_raw_parts) - [`Result::is_ok_and`] (https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.is_ok_and) - [`Result::is_err_and`] (https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.is_err_and) - [`std::sync::atomic::Atomic*::as_ptr`] (https://doc.rust-lang.org/stable/std/sync/atomic/struct.AtomicU8.html#method.as_ptr) - [`std::io::IsTerminal`] (https://doc.rust-lang.org/stable/std/io/trait.IsTerminal.html) - [`std::os::linux::net::SocketAddrExt`] (https://doc.rust-lang.org/stable/std/os/linux/net/trait.SocketAddrExt.html) - [`std::os::unix::net::UnixDatagram::bind_addr`] (https://doc.rust-lang.org/stable/std/os/unix/net/struct.UnixDatagram.html#method.bind_addr) - [`std::os::unix::net::UnixDatagram::connect_addr`] (https://doc.rust-lang.org/stable/std/os/unix/net/struct.UnixDatagram.html#method.connect_addr) - [`std::os::unix::net::UnixDatagram::send_to_addr`] (https://doc.rust-lang.org/stable/std/os/unix/net/struct.UnixDatagram.html#method.send_to_addr) - [`std::os::unix::net::UnixListener::bind_addr`] (https://doc.rust-lang.org/stable/std/os/unix/net/struct.UnixListener.html#method.bind_addr) - [`std::path::Path::as_mut_os_str`] (https://doc.rust-lang.org/stable/std/path/struct.Path.html#method.as_mut_os_str) - [`std::sync::OnceLock`] (https://doc.rust-lang.org/stable/std/sync/struct.OnceLock.html) Cargo ----- - [Add `CARGO_PKG_README`] (rust-lang/cargo#11645) - [Make `sparse` the default protocol for crates.io] (rust-lang/cargo#11791) - [Accurately show status when downgrading dependencies] (rust-lang/cargo#11839) - [Use registry.default for login/logout] (rust-lang/cargo#11949) - [Stabilize `cargo logout`] (rust-lang/cargo#11950) Misc ---- - [Stabilize rustdoc `--test-run-directory`] (rust-lang/rust#103682) Compatibility Notes ------------------- - [Prevent stable `libtest` from supporting `-Zunstable-options`] (rust-lang/rust#109044) - [Perform const and unsafe checking for expressions in `let _ = expr` position.] (rust-lang/rust#102256) - [WebAssembly targets enable `sign-ext` and `mutable-globals` features in codegen] (rust-lang/rust#109807) This may cause incompatibility with older execution environments. - [Insert alignment checks for pointer dereferences as debug assertions] (rust-lang/rust#98112) This catches undefined behavior at runtime, and may cause existing code to fail. Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Upgrade to LLVM 16] (rust-lang/rust#109474) - [Use SipHash-1-3 instead of SipHash-2-4 for StableHasher] (rust-lang/rust#107925)

jmqd · 2023-07-11T04:55:03Z

Thank you very much for this change, it enabled me to simplify some of my code after upgrading to 1.70.

danielhenrymantilla · 2023-09-03T16:02:58Z

Should there be a tracking issue for this trait?

CAD97 · 2023-09-03T19:17:42Z

It's currently marked as for internal use only, so that would suggest not having a tracking issue. The Tuple trait is a similar marker in purpose and also doesn't have a tracking issue.

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 15, 2023

lcnr reviewed Feb 15, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 15, 2023

compiler-errors reviewed Feb 15, 2023

View reviewed changes

compiler/rustc_trait_selection/src/solve/trait_goals.rs Outdated Show resolved Hide resolved

jackh726 mentioned this pull request Feb 18, 2023

builtin trait to abstract over function pointers #99531

Closed

lcnr added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Mar 6, 2023

oli-obk force-pushed the FnPtr-trait branch from 9df8e1b to f253bd3 Compare March 6, 2023 16:50

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 6, 2023

This comment has been minimized.

Sign in to view

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 28, 2023

bors merged commit bf57e8a into rust-lang:master Mar 28, 2023
12 checks passed

rustbot added this to the 1.70.0 milestone Mar 28, 2023

oli-obk deleted the FnPtr-trait branch March 28, 2023 15:20

apiraino removed the to-announce Announce this issue on triage meeting label Mar 30, 2023

eddyb mentioned this pull request Apr 3, 2023

FnPtr blanket impls cause "multiple applicable items in scope" for unrelated types. #109892

Closed

celinval mentioned this pull request Apr 26, 2023

Upgrade the toolchain to nightly-2023-04-16 model-checking/kani#2406

Merged

4 tasks

lcnr mentioned this pull request May 5, 2023

fn-ptr docs were not updated for the change to trait impls #111182

Open

pravic mentioned this pull request May 29, 2023

Github rejects rendering of RELEASES.md #112058

Closed

oli-obk added a commit to oli-obk/rust that referenced this pull request May 30, 2023

Remove a hack that has become obsolete after rust-lang#108080

7a2f47c

KamilaBorowska mentioned this pull request Jun 13, 2023

Primitive fn implementation list for Debug is ordered pretty much randomly #71859

Closed

lowr mentioned this pull request Jun 24, 2023

Support FnPtr trait rust-lang/chalk#798

Merged

Nilstrieb mentioned this pull request Jan 12, 2024

fn() Trait Implementations documentation no longer correct #119903

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a builtin `FnPtr` trait that is implemented for all function pointers #108080

Add a builtin `FnPtr` trait that is implemented for all function pointers #108080

oli-obk commented Feb 15, 2023

rustbot commented Feb 15, 2023

oli-obk commented Feb 15, 2023

This comment has been minimized.

bors commented Feb 15, 2023

lcnr Feb 15, 2023

lcnr Feb 15, 2023

oli-obk Feb 15, 2023

lcnr Feb 15, 2023

bors commented Feb 15, 2023

This comment has been minimized.

rust-timer commented Feb 15, 2023

lcnr commented Feb 15, 2023 •

edited

est31 commented Mar 6, 2023

oli-obk commented Mar 6, 2023

This comment has been minimized.

bors commented Mar 6, 2023

bors commented Mar 6, 2023

bors commented Mar 6, 2023

This comment has been minimized.

bors commented Mar 28, 2023

rust-timer commented Mar 28, 2023

oli-obk commented Mar 28, 2023

jmqd commented Jul 11, 2023

danielhenrymantilla commented Sep 3, 2023

CAD97 commented Sep 3, 2023

Add a builtin FnPtr trait that is implemented for all function pointers #108080

Add a builtin FnPtr trait that is implemented for all function pointers #108080

Conversation

oli-obk commented Feb 15, 2023

rustbot commented Feb 15, 2023

oli-obk commented Feb 15, 2023

This comment has been minimized.

bors commented Feb 15, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bors commented Feb 15, 2023

This comment has been minimized.

rust-timer commented Feb 15, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

lcnr commented Feb 15, 2023 • edited

est31 commented Mar 6, 2023

oli-obk commented Mar 6, 2023

This comment has been minimized.

bors commented Mar 6, 2023

bors commented Mar 6, 2023

bors commented Mar 6, 2023

This comment has been minimized.

bors commented Mar 28, 2023

rust-timer commented Mar 28, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

oli-obk commented Mar 28, 2023

jmqd commented Jul 11, 2023

danielhenrymantilla commented Sep 3, 2023

CAD97 commented Sep 3, 2023

Add a builtin `FnPtr` trait that is implemented for all function pointers #108080

Add a builtin `FnPtr` trait that is implemented for all function pointers #108080

lcnr commented Feb 15, 2023 •

edited