Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote loongarch64-unknown-linux-gnu to Tier 2 with host tools #110936

Merged
merged 1 commit into from May 24, 2023
Merged

Promote loongarch64-unknown-linux-gnu to Tier 2 with host tools #110936

merged 1 commit into from May 24, 2023
+5 −2

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Apr 28, 2023 •
edited

This PR promotes loongarch64-unknown-linux-gnu to Tier 2 (with host tools).

MCP: rust-lang/compiler-team#518

@rustbot
Copy link
Collaborator

rustbot commented Apr 28, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 28, 2023
@heiher heiher marked this pull request as draft April 28, 2023 08:19
xen0n
xen0n reviewed Apr 28, 2023
View reviewed changes
Copy link
Contributor

@xen0n xen0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for posting this early! For now it seems trivial enough and we only need to wait for the CI changes to first go in.

src/doc/rustc/src/platform-support.md Outdated
@@ -88,6 +88,7 @@ target | notes
`arm-unknown-linux-gnueabi` | ARMv6 Linux (kernel 3.2, glibc 2.17)
`arm-unknown-linux-gnueabihf` | ARMv6 Linux, hardfloat (kernel 3.2, glibc 2.17)
`armv7-unknown-linux-gnueabihf` | ARMv7 Linux, hardfloat (kernel 3.2, glibc 2.17)
[`loongarch64-unknown-linux-gnu`](platform-support/loongarch-linux.md) | LoongArch64 Linux, lp64d ABI (kernel 5.19, glibc 2.36)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[`loongarch64-unknown-linux-gnu`](platform-support/loongarch-linux.md) | LoongArch64 Linux, lp64d ABI (kernel 5.19, glibc 2.36)
[`loongarch64-unknown-linux-gnu`](platform-support/loongarch-linux.md) | LoongArch64 Linux, LP64D ABI (kernel 5.19, glibc 2.36)

@ehuss
Copy link
Contributor

ehuss commented Apr 28, 2023

r? compiler

@rustbot rustbot assigned TaKO8Ki and unassigned ehuss Apr 28, 2023
@jyn514
Copy link
Member

jyn514 commented Apr 29, 2023

r? infra

@rustbot rustbot assigned jdno and unassigned TaKO8Ki Apr 29, 2023
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2023
@heiher heiher marked this pull request as ready for review May 23, 2023 10:34
@heiher
Copy link
Contributor Author

heiher commented May 23, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 23, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 23, 2023

📌 Commit 03b8e03 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2023
@bors
Copy link
Contributor

bors commented May 24, 2023

⌛ Testing commit 03b8e03 with merge 9d826e0...

@bors
Copy link
Contributor

bors commented May 24, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 9d826e0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 24, 2023
@bors bors merged commit 9d826e0 into rust-lang:master May 24, 2023
12 checks passed
@rustbot rustbot added this to the 1.71.0 milestone May 24, 2023
@heiher heiher deleted the promote-tier2 branch May 24, 2023 05:08
@xen0n xen0n mentioned this pull request May 24, 2023
Closed
@heiher
Copy link
Contributor Author

heiher commented May 24, 2023

@rustbot label: +relnotes

@rustbot rustbot added the relnotes Marks issues that should be documented in the release notes of the next release. label May 24, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9d826e0): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.2% [0.2%, 0.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [0.2%, 0.2%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 647.241s -> 647.507s (0.04%)

@2moe 2moe mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xen0n xen0n xen0n left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@heiher @rustbot @ehuss @jyn514 @Mark-Simulacrum @bors @rust-timer @xen0n @jdno @TaKO8Ki