Change default panic handler message format. #112849

m-ou-se · 2023-06-20T17:30:42Z

Note: See below for the snippet for the Rust 1.73 release blog post.

This changes the default panic hook's message format from:

thread '{thread}' panicked at '{message}', {location}

to

thread '{thread}' panicked at {location}:
{message}

This puts the message on its own line without surrounding quotes, making it easiser to read. For example:

Before:

thread 'main' panicked at 'env variable `IMPORTANT_PATH` should be set by `wrapper_script.sh`', src/main.rs:4:6

After:

thread 'main' panicked at src/main.rs:4:6:
env variable `IMPORTANT_PATH` should be set by `wrapper_script.sh`

See this PR by @nyurik, which does that for only multi-line messages (specifically because of assert_eq): #111071

This is the change that does that for all panic messages.

m-ou-se · 2023-06-21T11:58:03Z

@craterbot run mode=build-and-test

craterbot · 2023-06-23T16:03:10Z

🎉 Experiment pr-112849 is completed!
📊 210 regressed and 118 fixed (303810 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

nyurik · 2023-08-01T16:30:28Z

Thx everyone for getting this one through! Turns out the simplest PRs are the hardest to merge :)

I re-based #111071 on top of the main branch, so now its much simpler. I think we should release both panic message changes in the same release if possible, as they are closely related.

rust-timer · 2023-08-01T20:41:39Z

Finished benchmarking commit (828bdc2): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	2
Improvements ✅ (secondary)	-0.4%	[-0.5%, -0.3%]	4
All ❌✅ (primary)	-0.4%	[-0.4%, -0.4%]	2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.5%	[-4.5%, -4.5%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[1.7%, 4.5%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-5.3%, -1.4%]	4
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data

lqd · 2023-08-01T21:22:03Z

@rust-lang/wg-compiler-performance: We may need to do something about #114318 breaking the bootstrap timings. They're still missing for more recent PRs, like this one.

m-ou-se · 2023-08-15T10:34:42Z

Snippet for the release blog post (in Markdown), for both this PR and #111071:

## Cleaner panic messages

The output produced by the default panic handler has been changed
to put the panic message on its own line instead of wrapping it in quotes.
This can make panic messages easier to read, as shown in this example:

<div style="margin:1em"><pre><code>fn main() {
    let file = "ferris.txt";
    panic!("oh no! {file:?} not found!");
}</code></pre>
Output before Rust 1.73:
<pre style="margin-top:0"><code style="background:#000;color:#ccc" class="language-text">thread 'main' panicked at 'oh no! "ferris.txt" not found!', src/main.rs:3:5</code></pre>
Output starting in Rust 1.73:
<pre style="margin-top:0"><code style="background:#000;color:#ccc" class="language-text">thread 'main' panicked at src/main.rs:3:5:
oh no! "ferris.txt" not found!</code></pre></div>

This is especially useful when the message is long, contains nested quotes, or spans multiple lines.

Additionally, the panic messages produced by `assert_eq` and `assert_ne` have
been modified, moving the custom message (the third argument)
and removing some unnecessary punctuation, as shown below:

<div style="margin:1em"><pre><code>fn main() {
    assert_eq!("🦀", "🐟", "ferris is not a fish");
}</code></pre>
Output before Rust 1.73:
<pre style="margin-top:0"><code style="background:#000;color:#ccc" class="language-text">thread 'main' panicked at 'assertion failed: `(left == right)`
 left: `"🦀"`,
right: `"🐟"`: ferris is not a fish', src/main.rs:2:5</code></pre>
Output starting in Rust 1.73:
<pre style="margin-top:0"><code style="background:#000;color:#ccc" class="language-text">thread 'main' panicked at src/main.rs:2:5:
assertion `left == right` failed: ferris is not a fish
 left: "🦀"
right: "🐟"</code></pre></div>

Rendered

Cleaner assert_eq! & assert_ne! panic messages This PR finishes refactoring of the assert messages per rust-lang#94005. The panic message format change rust-lang#112849 used to be part of this PR, but has been factored out and just merged. It might be better to keep both changes in the same release once FCP vote completes. Modify panic message for `assert_eq!`, `assert_ne!`, the currently unstable `assert_matches!`, as well as the corresponding `debug_assert_*` macros. ```rust assert_eq!(1 + 1, 3); assert_eq!(1 + 1, 3, "my custom message value={}!", 42); ``` #### Old messages ```plain thread 'main' panicked at $DIR/main.rs:6:5: assertion failed: `(left == right)` left: `2`, right: `3` ``` ```plain thread 'main' panicked at $DIR/main.rs:6:5: assertion failed: `(left == right)` left: `2`, right: `3`: my custom message value=42! ``` #### New messages ```plain thread 'main' panicked at $DIR/main.rs:6:5: assertion `left == right` failed left: 2 right: 3 ``` ```plain thread 'main' panicked at $DIR/main.rs:6:5: assertion `left == right` failed: my custom message value=42! left: 2 right: 3 ``` History of fixing rust-lang#94005 * rust-lang#94016 was a lengthy PR that was abandoned * rust-lang#111030 was similar, but it stringified left and right arguments, and thus caused compile time performance issues, thus closed * rust-lang#112849 factored out the two-line formatting of all panic messages Fixes rust-lang#94005 r? `@m-ou-se`

Language -------- - [Uplift `clippy::fn_null_check` lint as `useless_ptr_null_checks`.] (rust-lang/rust#111717) - [Make `noop_method_call` warn by default.] (rust-lang/rust#111916) - [Support interpolated block for `try` and `async` in macros.] (rust-lang/rust#112953) - [Make `unconditional_recursion` lint detect recursive drops.] (rust-lang/rust#113902) - [Future compatibility warning for some impls being incorrectly considered not overlapping.] (rust-lang/rust#114023) - [The `invalid_reference_casting` lint is now **deny-by-default** (instead of allow-by-default)] (rust-lang/rust#112431) Compiler -------- - [Write version information in a `.comment` section like GCC/Clang.] (rust-lang/rust#97550) - [Add documentation on v0 symbol mangling.] (rust-lang/rust#97571) - [Stabilize `extern "thiscall"` and `"thiscall-unwind"` ABIs.] (rust-lang/rust#114562) - [Only check outlives goals on impl compared to trait.] (rust-lang/rust#109356) - [Infer type in irrefutable slice patterns with fixed length as array.] (rust-lang/rust#113199) - [Discard default auto trait impls if explicit ones exist.] (rust-lang/rust#113312) - Add several new tier 3 targets: - [`aarch64-unknown-teeos`] (rust-lang/rust#113480) - [`csky-unknown-linux-gnuabiv2`] (rust-lang/rust#113658) - [`riscv64-linux-android`] (rust-lang/rust#112858) - [`riscv64gc-unknown-hermit`] (rust-lang/rust#114004) - [`x86_64-unikraft-linux-musl`] (rust-lang/rust#113411) - [`x86_64-unknown-linux-ohos`] (rust-lang/rust#113061) - [Add `wasm32-wasi-preview1-threads` as a tier 2 target.] (rust-lang/rust#112922) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Add `Read`, `Write` and `Seek` impls for `Arc<File>`.] (rust-lang/rust#94748) - [Merge functionality of `io::Sink` into `io::Empty`.] (rust-lang/rust#98154) - [Implement `RefUnwindSafe` for `Backtrace`] (rust-lang/rust#100455) - [Make `ExitStatus` implement `Default`] (rust-lang/rust#106425) - [`impl SliceIndex<str> for (Bound<usize>, Bound<usize>)`] (rust-lang/rust#111081) - [Change default panic handler message format.] (rust-lang/rust#112849) - [Cleaner `assert_eq!` & `assert_ne!` panic messages.] (rust-lang/rust#111071) - [Correct the (deprecated) Android `stat` struct definitions.] (rust-lang/rust#113130) Stabilized APIs --------------- - [Unsigned `{integer}::div_ceil`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.div_ceil) - [Unsigned `{integer}::next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.next_multiple_of) - [Unsigned `{integer}::checked_next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.checked_next_multiple_of) - [`std::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/std/ffi/struct.FromBytesUntilNulError.html) - [`std::os::unix::fs::chown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.chown.html) - [`std::os::unix::fs::fchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.fchown.html) - [`std::os::unix::fs::lfchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.lchown.html) - [`LocalKey::<Cell<T>>::get`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.get) - [`LocalKey::<Cell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set) - [`LocalKey::<Cell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take) - [`LocalKey::<Cell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace) - [`LocalKey::<RefCell<T>>::with_borrow`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow) - [`LocalKey::<RefCell<T>>::with_borrow_mut`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow_mut) - [`LocalKey::<RefCell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set-1) - [`LocalKey::<RefCell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take-1) - [`LocalKey::<RefCell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace-1) These APIs are now stable in const contexts: - [`rc::Weak::new`] (https://doc.rust-lang.org/stable/alloc/rc/struct.Weak.html#method.new) - [`sync::Weak::new`] (https://doc.rust-lang.org/stable/alloc/sync/struct.Weak.html#method.new) - [`NonNull::as_ref`] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.as_ref) Cargo ----- - [Encode URL params correctly for `SourceId` in `Cargo.lock`.] (rust-lang/cargo#12280) - [Bail out an error when using `cargo::` in custom build script.] (rust-lang/cargo#12332) Compatibility Notes ------------------- - [Update the minimum external LLVM to 15.] (rust-lang/rust#114148) - [Check for non-defining uses of return position `impl Trait`.] (rust-lang/rust#112842) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Remove LLVM pointee types, supporting only opaque pointers.] (rust-lang/rust#105545) - [Port PGO/LTO/BOLT optimized build pipeline to Rust.] (rust-lang/rust#112235) - [Replace in-tree `rustc_apfloat` with the new version of the crate.] (rust-lang/rust#113843) - [Update to LLVM 17.] (rust-lang/rust#114048) - [Add `internal_features` lint for internal unstable features.] (rust-lang/rust#108955) - [Mention style for new syntax in tracking issue template.] (rust-lang/rust#113586)

safinaskar · 2023-10-07T11:05:05Z

Despite all this effort, bug #108341 still persists. I. e. I still see ugly \n in assert output if line is too long

safinaskar · 2023-10-07T11:11:23Z

Also, backtraces are still completely impossible to understand: #99560

workingjubilee · 2023-10-08T01:00:30Z

Naturally. This PR was not intended to fix either of those problems. If you want to help us improve our panic and backtrace diagnostics, a good first step would be to find all the issues that have to deal with panic and labeling them like so:

@rustbot label: +A-panic

That is something anyone can do, and it will significantly help us sort these issues out by making it easier to try to figure out which issues are related to each other.

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. * For an external LLVM, set dependency of llvm >= 15, in accordance with the upstream changes. * Add a patch with a backport from LLVM 17.0.3 fixing codegen for PPC, ref. rust-lang/rust#116845 Upstream changes: Version 1.73.0 (2023-10-05) ========================== Language -------- - [Uplift `clippy::fn_null_check` lint as `useless_ptr_null_checks`.] (rust-lang/rust#111717) - [Make `noop_method_call` warn by default.] (rust-lang/rust#111916) - [Support interpolated block for `try` and `async` in macros.] (rust-lang/rust#112953) - [Make `unconditional_recursion` lint detect recursive drops.] (rust-lang/rust#113902) - [Future compatibility warning for some impls being incorrectly considered not overlapping.] (rust-lang/rust#114023) - [The `invalid_reference_casting` lint is now **deny-by-default** (instead of allow-by-default)] (rust-lang/rust#112431 Compiler -------- - [Write version information in a `.comment` section like GCC/Clang.] (rust-lang/rust#97550) - [Add documentation on v0 symbol mangling.] (rust-lang/rust#97571) - [Stabilize `extern "thiscall"` and `"thiscall-unwind"` ABIs.] (rust-lang/rust#114562) - [Only check outlives goals on impl compared to trait.] (rust-lang/rust#109356) - [Infer type in irrefutable slice patterns with fixed length as array.] (rust-lang/rust#113199) - [Discard default auto trait impls if explicit ones exist.] (rust-lang/rust#113312) - Add several new tier 3 targets: - [`aarch64-unknown-teeos`] (rust-lang/rust#113480) - [`csky-unknown-linux-gnuabiv2`] (rust-lang/rust#113658) - [`riscv64-linux-android`] (rust-lang/rust#112858) - [`riscv64gc-unknown-hermit`] (rust-lang/rust#114004) - [`x86_64-unikraft-linux-musl`] (rust-lang/rust#113411) - [`x86_64-unknown-linux-ohos`] (rust-lang/rust#113061) - [Add `wasm32-wasi-preview1-threads` as a tier 2 target.] (rust-lang/rust#112922) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Add `Read`, `Write` and `Seek` impls for `Arc<File>`.] (rust-lang/rust#94748) - [Merge functionality of `io::Sink` into `io::Empty`.] (rust-lang/rust#98154) - [Implement `RefUnwindSafe` for `Backtrace`] (rust-lang/rust#100455) - [Make `ExitStatus` implement `Default`] (rust-lang/rust#106425) - [`impl SliceIndex<str> for (Bound<usize>, Bound<usize>)`] (rust-lang/rust#111081) - [Change default panic handler message format.] (rust-lang/rust#112849) - [Cleaner `assert_eq!` & `assert_ne!` panic messages.] (rust-lang/rust#111071) - [Correct the (deprecated) Android `stat` struct definitions.] (rust-lang/rust#113130) Stabilized APIs --------------- - [Unsigned `{integer}::div_ceil`] (https://doc.rust-lang.org/stable/std/primitiv e.u32.html#method.div_ceil) - [Unsigned `{integer}::next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.next_multiple_of) - [Unsigned `{integer}::checked_next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.checked_next_multiple_of) - [`std::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/std/ffi/struct.FromBytesUntilNulError.html) - [`std::os::unix::fs::chown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.chown.html) - [`std::os::unix::fs::fchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.fchown.html) - [`std::os::unix::fs::lfchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.lchown.html) - [`LocalKey::<Cell<T>>::get`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.get) - [`LocalKey::<Cell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set) - [`LocalKey::<Cell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take) - [`LocalKey::<Cell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace) - [`LocalKey::<RefCell<T>>::with_borrow`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow) - [`LocalKey::<RefCell<T>>::with_borrow_mut`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow_mut) - [`LocalKey::<RefCell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set-1) - [`LocalKey::<RefCell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take-1) - [`LocalKey::<RefCell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace-1) These APIs are now stable in const contexts: - [`rc::Weak::new`] (https://doc.rust-lang.org/stable/alloc/rc/struct.Weak.html#method.new) - [`sync::Weak::new`] (https://doc.rust-lang.org/stable/alloc/sync/struct.Weak.html#method.new) - [`NonNull::as_ref`] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.as_ref) Cargo ----- - [Encode URL params correctly for `SourceId` in `Cargo.lock`.] (rust-lang/cargo#12280) - [Bail out an error when using `cargo::` in custom build script.] (rust-lang/cargo#12332) Misc ---- Compatibility Notes ------------------- - [Update the minimum external LLVM to 15.] (rust-lang/rust#114148) - [Check for non-defining uses of return position `impl Trait`.] (rust-lang/rust#112842) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Remove LLVM pointee types, supporting only opaque pointers.] (rust-lang/rust#105545) - [Port PGO/LTO/BOLT optimized build pipeline to Rust.] (rust-lang/rust#112235) - [Replace in-tree `rustc_apfloat` with the new version of the crate.] (rust-lang/rust#113843) - [Update to LLVM 17.] (rust-lang/rust#114048) - [Add `internal_features` lint for internal unstable features.] (rust-lang/rust#108955) - [Mention style for new syntax in tracking issue template.] (rust-lang/rust#113586)

The latest rust nightly changed the formatting of panic messages in rust-lang/rust#112849 so that the message now comes after the source info. This CL updates all checks against the panic message to properly match the new format. Bug: 130265 Test: fx test component_manager_logger_test rust-runner-integration-test host_x64/obj/tools/testing/testparser/test.sh host_x64/symbolizer_tests Change-Id: Idcb28b8c9a3269f0e1534b703d9231e8d452d801 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/900340 Reviewed-by: Dangyi Liu <dangyi@google.com> Reviewed-by: Adam Perry <adamperry@google.com> Reviewed-by: Ankur Mittal <anmittal@google.com> Reviewed-by: Tyler Mandry <tmandry@google.com> Commit-Queue: Tyler Mandry <tmandry@google.com> Reviewed-by: Mike McCreavy <mccreavy@google.com>

m-ou-se self-assigned this Jun 20, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2023

m-ou-se mentioned this pull request Jun 20, 2023

Cleaner assert_eq! & assert_ne! panic messages #111071

Merged

This comment was marked as outdated.

Sign in to view

m-ou-se removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2023

This comment has been minimized.

Sign in to view

m-ou-se force-pushed the panic-message-format branch from 8897295 to 6e94a79 Compare June 20, 2023 17:59

This comment has been minimized.

Sign in to view

m-ou-se force-pushed the panic-message-format branch from 6e94a79 to 669ab82 Compare June 20, 2023 18:29

This comment has been minimized.

Sign in to view

m-ou-se force-pushed the panic-message-format branch from 669ab82 to 0002c78 Compare June 20, 2023 20:37

This comment has been minimized.

Sign in to view

m-ou-se force-pushed the panic-message-format branch from 0002c78 to 3bb4bb1 Compare June 21, 2023 08:59

This comment was marked as outdated.

Sign in to view

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. labels Jun 21, 2023

This comment was marked as outdated.

Sign in to view

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 23, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 1, 2023

bors merged commit 828bdc2 into rust-lang:master Aug 1, 2023
12 checks passed

rustbot added this to the 1.73.0 milestone Aug 1, 2023

This was referenced Aug 1, 2023

core, std, proc_macro: inline format!() args (1) #114067

Closed

[DO NOT MERGE] Revert "Eliminate ZST allocations in Box and Vec" #114086

Closed

m-ou-se deleted the panic-message-format branch August 1, 2023 18:34

aochagavia mentioned this pull request Aug 2, 2023

Performance measurements for day-to-day development of Rustls rustls/rustls#1385

Closed

smoelius added a commit to trailofbits/cast_checks that referenced this pull request Aug 4, 2023

Account for rust-lang/rust#112849

3d6dc3c

smoelius added a commit to trailofbits/cast_checks that referenced this pull request Aug 4, 2023

Account for rust-lang/rust#112849

642c5d9

nbdd0121 mentioned this pull request Aug 5, 2023

Initial libstd support nbdd0121/unwinding#17

Merged

sribich mentioned this pull request Aug 21, 2023

fix: support new panic message format in rust 1.73 moonrepo/moon#1011

Merged

tgross35 mentioned this pull request Sep 11, 2023

Print thread ID in panic message if thread name is unknown #115746

Open

Mark-Simulacrum mentioned this pull request Sep 30, 2023

1.73 announcement rust-lang/blog.rust-lang.org#1149

Merged

rustbot added the A-panic Area: Panicking machinery label Oct 8, 2023

StackOverflowExcept1on mentioned this pull request Nov 26, 2023

Proposal: get rid of nightly features in gstd gear-tech/gear#3524

Closed

dtolnay mentioned this pull request Jan 2, 2024

Update test snapshots for Rust 1.73+'s panic formatting aaronabramov/k9#131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change default panic handler message format. #112849

Change default panic handler message format. #112849

m-ou-se commented Jun 20, 2023 •

edited

This comment was marked as outdated.

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

m-ou-se commented Jun 21, 2023

This comment was marked as outdated.

This comment was marked as outdated.

craterbot commented Jun 23, 2023

nyurik commented Aug 1, 2023

rust-timer commented Aug 1, 2023

lqd commented Aug 1, 2023

m-ou-se commented Aug 15, 2023 •

edited

safinaskar commented Oct 7, 2023

safinaskar commented Oct 7, 2023

workingjubilee commented Oct 8, 2023

Change default panic handler message format. #112849

Change default panic handler message format. #112849

Conversation

m-ou-se commented Jun 20, 2023 • edited

This comment was marked as outdated.

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

m-ou-se commented Jun 21, 2023

This comment was marked as outdated.

This comment was marked as outdated.

craterbot commented Jun 23, 2023

nyurik commented Aug 1, 2023

rust-timer commented Aug 1, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

lqd commented Aug 1, 2023

m-ou-se commented Aug 15, 2023 • edited

safinaskar commented Oct 7, 2023

safinaskar commented Oct 7, 2023

workingjubilee commented Oct 8, 2023

m-ou-se commented Jun 20, 2023 •

edited

m-ou-se commented Aug 15, 2023 •

edited