Implement `From<[T; N]>` for `Rc<[T]>` and `Arc<[T]>` #114041

nvzqz · 2023-07-25T02:00:06Z

Given that Box<[T]> already has this conversion, the shared counterparts should also have it.

rustbot · 2023-07-25T02:00:14Z

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

nvzqz · 2023-07-25T02:01:28Z

@rustbot label +T-libs-api -T-libs

thomcc · 2023-07-25T02:02:58Z

Libs-api, needs FCP too. (Not sure if ACP is still needed for insta-stable trait impls?)

r? @rust-lang/libs-api

thomcc · 2023-07-25T02:04:05Z

Ah, IIRC @BurntSushi doesn't have time for reviews, so r? @Amanieu

library/alloc/src/rc.rs

library/alloc/src/sync.rs

Amanieu · 2023-07-25T23:26:24Z

This seems reasonable, we already have the same for Vec and Box<[T]>.

@rfcbot fcp merge

rfcbot · 2023-07-25T23:26:25Z

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2023-08-22T13:34:47Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2023-09-01T13:36:04Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

dtolnay

Thanks!

dtolnay · 2023-09-28T03:21:23Z

@bors r+

bors · 2023-09-28T03:21:25Z

📌 Commit b2d35e1 has been approved by dtolnay

It is now in the queue for this repository.

bors · 2023-09-28T06:16:05Z

⌛ Testing commit b2d35e1 with merge 46da927...

bors · 2023-09-28T08:04:31Z

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 46da927 to master...

rust-timer · 2023-09-28T09:34:04Z

Finished benchmarking commit (46da927): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.4%	[-1.4%, -1.4%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.947s -> 631.429s (-0.08%)
Artifact size: 317.35 MiB -> 317.33 MiB (-0.01%)

Pkgsrc changes: * Remove NetBSD-8 support (embedded LLVm requires newer C++ than what is in -8; it's conceivable that this could still build with an external LLVM) * undo powerpc 9.0 file naming tweak, since we no longer support -8. * Remove patch to LLVM for powerpc now included by upstream. * Minor adjustments, checksum changes etc. Upstream changes: Version 1.74.1 (2023-12-07) =========================== - [Resolved spurious STATUS_ACCESS_VIOLATIONs in LLVM] (rust-lang/rust#118464) - [Clarify guarantees for std::mem::discriminant] (rust-lang/rust#118006) - [Fix some subtyping-related regressions] (rust-lang/rust#116415) Version 1.74.0 (2023-11-16) ========================== Language -------- - [Codify that `std::mem::Discriminant<T>` does not depend on any lifetimes in T] (rust-lang/rust#104299) - [Replace `private_in_public` lint with `private_interfaces` and `private_bounds` per RFC 2145] (rust-lang/rust#113126) Read more in [RFC 2145](https://rust-lang.github.io/rfcs/2145-type-privacy.html). - [Allow explicit `#[repr(Rust)]`] (rust-lang/rust#114201) - [closure field capturing: don't depend on alignment of packed fields] (rust-lang/rust#115315) - [Enable MIR-based drop-tracking for `async` blocks] (rust-lang/rust#107421) Compiler -------- - [stabilize combining +bundle and +whole-archive link modifiers] (rust-lang/rust#113301) - [Stabilize `PATH` option for `--print KIND=PATH`] (rust-lang/rust#114183) - [Enable ASAN/LSAN/TSAN for `*-apple-ios-macabi`] (rust-lang/rust#115644) - [Promote loongarch64-unknown-none* to Tier 2] (rust-lang/rust#115368) - [Add `i686-pc-windows-gnullvm` as a tier 3 target] (rust-lang/rust#115687) Libraries --------- - [Implement `From<OwnedFd/Handle>` for ChildStdin/out/err] (rust-lang/rust#98704) - [Implement `From<{&,&mut} [T; N]>` for `Vec<T>` where `T: Clone`] (rust-lang/rust#111278) - [impl Step for IP addresses] (rust-lang/rust#113748) - [Implement `From<[T; N]>` for `Rc<[T]>` and `Arc<[T]>`] (rust-lang/rust#114041) - [`impl TryFrom<char> for u16`] (rust-lang/rust#114065) - [Stabilize `io_error_other` feature] (rust-lang/rust#115453) - [Stabilize the `Saturating` type] (rust-lang/rust#115477) - [Stabilize const_transmute_copy] (rust-lang/rust#115520) Stabilized APIs --------------- - [`core::num::Saturating`] (https://doc.rust-lang.org/stable/std/num/struct.Saturating.html) - [`impl From<io::Stdout> for std::process::Stdio`] (https://doc.rust-lang.org/stable/std/process/struct.Stdio.html#impl-From%3CStdout%3E-for-Stdio) - [`impl From<io::Stderr> for std::process::Stdio`] (https://doc.rust-lang.org/stable/std/process/struct.Stdio.html#impl-From%3CStderr%3E-for-Stdio) - [`impl From<OwnedHandle> for std::process::Child{Stdin, Stdout, Stderr}`] (https://doc.rust-lang.org/stable/std/process/struct.Stdio.html#impl-From%3CStderr%3E-for-Stdio) - [`impl From<OwnedFd> for std::process::Child{Stdin, Stdout, Stderr}`] (https://doc.rust-lang.org/stable/std/process/struct.Stdio.html#impl-From%3CStderr%3E-for-Stdio) - [`std::ffi::OsString::from_encoded_bytes_unchecked`] (https://doc.rust-lang.org/stable/std/ffi/struct.OsString.html#method.from_encoded_bytes_unchecked) - [`std::ffi::OsString::into_encoded_bytes`] (https://doc.rust-lang.org/stable/std/ffi/struct.OsString.html#method.into_encoded_bytes) - [`std::ffi::OsStr::from_encoded_bytes_unchecked`] (https://doc.rust-lang.org/stable/std/ffi/struct.OsStr.html#method.from_encoded_bytes_unchecked) - [`std::ffi::OsStr::as_encoded_bytes`] (https://doc.rust-lang.org/stable/std/ffi/struct.OsStr.html#method.as_encoded_bytes) - [`std::io::Error::other`] (https://doc.rust-lang.org/stable/std/io/struct.Error.html#method.other) - [`impl TryFrom<char> for u16`] (https://doc.rust-lang.org/stable/std/primitive.u16.html#impl-TryFrom%3Cchar%3E-for-u16) - [`impl<T: Clone, const N: usize> From<&[T; N]> for Vec<T>`] (https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#impl-From%3C%26%5BT;+N%5D%3E-for-Vec%3CT,+Global%3E) - [`impl<T: Clone, const N: usize> From<&mut [T; N]> for Vec<T>`] (https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#impl-From%3C%26mut+%5BT;+N%5D%3E-for-Vec%3CT,+Global%3E) - [`impl<T, const N: usize> From<[T; N]> for Arc<[T]>`] (https://doc.rust-lang.org/stable/std/sync/struct.Arc.html#impl-From%3C%5BT;+N%5D%3E-for-Arc%3C%5BT%5D,+Global%3E) - [`impl<T, const N: usize> From<[T; N]> for Rc<[T]>`] (https://doc.rust-lang.org/stable/std/rc/struct.Rc.html#impl-From%3C%5BT;+N%5D%3E-for-Rc%3C%5BT%5D,+Global%3E) These APIs are now stable in const contexts: - [`core::mem::transmute_copy`] (https://doc.rust-lang.org/beta/std/mem/fn.transmute_copy.html) - [`str::is_ascii`] (https://doc.rust-lang.org/beta/std/primitive.str.html#method.is_ascii) - [`[u8]::is_ascii`] (https://doc.rust-lang.org/beta/std/primitive.slice.html#method.is_ascii) Cargo ----- - [fix: Set MSRV for internal packages] (rust-lang/cargo#12381) - [config: merge lists in precedence order] (rust-lang/cargo#12515) - [fix(update): Clarify meaning of --aggressive as --recursive] (rust-lang/cargo#12544) - [fix(update): Make `-p` more convenient by being positional] (rust-lang/cargo#12545) - [feat(help): Add styling to help output ] (rust-lang/cargo#12578) - [feat(pkgid): Allow incomplete versions when unambigious] (rust-lang/cargo#12614) - [feat: stabilize credential-process and registry-auth] (rust-lang/cargo#12649) - [feat(cli): Add '-n' to dry-run] (rust-lang/cargo#12660) - [Add support for `target.'cfg(..)'.linker`] (rust-lang/cargo#12535) - [Stabilize `--keep-going`] (rust-lang/cargo#12568) - [feat: Stabilize lints] (rust-lang/cargo#12648) Rustdoc ------- - [Add warning block support in rustdoc] (rust-lang/rust#106561) - [Accept additional user-defined syntax classes in fenced code blocks] (rust-lang/rust#110800) - [rustdoc-search: add support for type parameters] (rust-lang/rust#112725) - [rustdoc: show inner enum and struct in type definition for concrete type] (rust-lang/rust#114855) Compatibility Notes ------------------- - [Raise minimum supported Apple OS versions] (rust-lang/rust#104385) - [make Cell::swap panic if the Cells partially overlap] (rust-lang/rust#114795) - [Reject invalid crate names in `--extern`] (rust-lang/rust#116001) - [Don't resolve generic impls that may be shadowed by dyn built-in impls] (rust-lang/rust#114941) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. None this cycle.

rustbot assigned thomcc Jul 25, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 25, 2023

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 25, 2023

rustbot assigned BurntSushi and unassigned thomcc Jul 25, 2023

rustbot assigned Amanieu and unassigned BurntSushi Jul 25, 2023

chenyukang reviewed Jul 25, 2023

View reviewed changes

library/alloc/src/rc.rs Show resolved Hide resolved

chenyukang reviewed Jul 25, 2023

View reviewed changes

library/alloc/src/sync.rs Show resolved Hide resolved

Implement From<[T; N]> for Rc<[T]> and Arc<[T]>

b2d35e1

nvzqz force-pushed the nvzqz/shared_from_array branch from ee92e77 to b2d35e1 Compare July 25, 2023 02:15

This comment was marked as resolved.

Sign in to view

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 25, 2023

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Aug 22, 2023

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Sep 1, 2023

rfcbot added the to-announce Announce this issue on triage meeting label Sep 1, 2023

apiraino removed the to-announce Announce this issue on triage meeting label Sep 7, 2023

dtolnay assigned dtolnay and unassigned Amanieu Sep 28, 2023

dtolnay approved these changes Sep 28, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 28, 2023

bors merged commit 46da927 into rust-lang:master Sep 28, 2023
12 checks passed

rustbot added this to the 1.74.0 milestone Sep 28, 2023

apiraino mentioned this pull request Feb 1, 2024

Reverse regression: unsized coercion from array to slice in Arc::from started compiling in 1.74.0 #120541

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement `From<[T; N]>` for `Rc<[T]>` and `Arc<[T]>` #114041

Implement `From<[T; N]>` for `Rc<[T]>` and `Arc<[T]>` #114041

nvzqz commented Jul 25, 2023

rustbot commented Jul 25, 2023

nvzqz commented Jul 25, 2023

thomcc commented Jul 25, 2023

thomcc commented Jul 25, 2023

This comment was marked as resolved.

This comment was marked as resolved.

Amanieu commented Jul 25, 2023

rfcbot commented Jul 25, 2023 •

edited by BurntSushi

rfcbot commented Aug 22, 2023

rfcbot commented Sep 1, 2023

dtolnay left a comment

dtolnay commented Sep 28, 2023

bors commented Sep 28, 2023

bors commented Sep 28, 2023

bors commented Sep 28, 2023

rust-timer commented Sep 28, 2023

Implement From<[T; N]> for Rc<[T]> and Arc<[T]> #114041

Implement From<[T; N]> for Rc<[T]> and Arc<[T]> #114041

Conversation

nvzqz commented Jul 25, 2023

rustbot commented Jul 25, 2023

nvzqz commented Jul 25, 2023

thomcc commented Jul 25, 2023

thomcc commented Jul 25, 2023

This comment was marked as resolved.

This comment was marked as resolved.

Amanieu commented Jul 25, 2023

rfcbot commented Jul 25, 2023 • edited by BurntSushi

rfcbot commented Aug 22, 2023

rfcbot commented Sep 1, 2023

dtolnay left a comment

Choose a reason for hiding this comment

dtolnay commented Sep 28, 2023

bors commented Sep 28, 2023

bors commented Sep 28, 2023

bors commented Sep 28, 2023

rust-timer commented Sep 28, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Implement `From<[T; N]>` for `Rc<[T]>` and `Arc<[T]>` #114041

Implement `From<[T; N]>` for `Rc<[T]>` and `Arc<[T]>` #114041

rfcbot commented Jul 25, 2023 •

edited by BurntSushi