[RFC] Support `.comment` section like GCC/Clang (`!llvm.ident`) #97550

ojeda · 2022-05-30T13:00:36Z

Both GCC and Clang write by default a .comment section with compiler information:

$ gcc -c -xc /dev/null && readelf -p '.comment' null.o

String dump of section '.comment':
  [     1]  GCC: (GNU) 11.2.0

$ clang -c -xc /dev/null && readelf -p '.comment' null.o

String dump of section '.comment':
  [     1]  clang version 14.0.1 (https://github.com/llvm/llvm-project.git c62053979489ccb002efe411c3af059addcb5d7d)

They also implement the -Qn flag to avoid doing so:

$ gcc -Qn -c -xc /dev/null && readelf -p '.comment' null.o
readelf: Warning: Section '.comment' was not dumped because it does not exist!

$ clang -Qn -c -xc /dev/null && readelf -p '.comment' null.o
readelf: Warning: Section '.comment' was not dumped because it does not exist!

So far, rustc only does it for WebAssembly targets and only when debug info is enabled:

$ echo 'fn main(){}' | rustc --target=wasm32-unknown-unknown --emit=llvm-ir -Cdebuginfo=2 - && grep llvm.ident rust_out.ll
!llvm.ident = !{!27}

The RFC part of this PR is about which behavior should rustc follow:

Always add it.
Add it by default, i.e. have an opt-out flag (GCC, Clang).
Have an opt-in flag.
Never add it (current).

There is also the question of whether debug info being enabled matters for that decision, given the current behavior of WebAssembly targets.

For instance, adding it by default gets us closer to other popular compilers, but that may surprise some users with an information leak. The most conservative option is to only do so opt-in, even if debug info is enabled (some users may be stripping debug info and not expecting something else to be leaked elsewhere).

Implementation-wise, this covers both ModuleLlvm::new() and ModuleLlvm::new_metadata() cases by moving the addition to context::create_module and adds a few test cases.

ThinLTO also sees the llvm.ident named metadata duplicated (in temporary outputs), so this deduplicates it like it is done for wasm.custom_sections. The tests also check this duplication does not take place.

rust-highfive · 2022-05-30T13:00:40Z

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

bjorn3 · 2022-05-30T14:52:01Z

I'm surprised this wasn't already added.

For instance, adding it by default gets us closer to other popular compilers, but that may surprise some users with an information leak.

I am pretty sure it is already possible to reliably identify the exact rustc version used soly based on the standard library functions linked into the executable. Without stripping you can trivially lookup the stable crate id from a libcore symbol name (the stable crate id depends among other things on the rustc version) and even without symbols I'm pretty sure there are enough differences between versions to identify which rustc is used. In any case it will be possible to at least identify that rustc is used if you don't restrict yourself to #![no_std] and avoid calling every non-trivial function in libcore and enable LTO.

ojeda · 2022-05-30T15:18:23Z

Without stripping

Yeah, I am just trying to look at it from the shoes of users working on proprietary software where it is common to strip it and clean/obfuscate/tweak binaries in further ways. Some of them may suddenly realize their executable is now explicitly marked and come to complain about it (even if they should be checking for extraneous sections anyway).

even without symbols

Definitely, I am sure it is possible to find fancier ways. I wouldn't be surprised if NNs are being applied to the problem already. :)

lcnr · 2022-05-30T15:28:46Z

r? @bjorn3

Considering that this is annotated as [RFC], maybe you should open a PR to https://github.com/rust-lang/rfcs/ instead? Don't know how complex of a decision this is, so maybe a compiler team MCP is enough?

ojeda · 2022-05-30T15:30:19Z

(@bjorn3 To be clear, I wouldn't mind doing it by default and getting closer to GCC and Clang; I am just playing devil's advocate)

ojeda · 2022-05-30T15:32:42Z

Considering that this is annotated as [RFC], maybe you should open a PR to https://github.com/rust-lang/rfcs/ instead? Don't know how complex of a decision this is, so maybe a compiler team MCP is enough?

Definitely, if it is deemed necessary, I can write one. I wasn't sure, so I tagged it here for the moment. Thanks!

est31 · 2022-05-30T15:43:23Z

FWIW, rustc is already setting the producer string and adding it to debuginfo:

rust/compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs

Lines 813 to 816 in 0f06824

    
           let rustc_producer = 
        
               format!("rustc version {}", option_env!("CFG_VERSION").expect("CFG_VERSION"),); 
        
           // FIXME(#41252) Remove "clang LLVM" if we can get GDB and LLVM to play nice. 
        
           let producer = format!("clang LLVM ({})", rustc_producer);

This is what you get when you run strings on rustc output that has debuginfo:

$ echo 'fn main(){}' | rustc -Cdebuginfo=2 - && strings rust_out | rg "rustc version"
clang LLVM (rustc version 1.62.0-beta.2 (daf68b1f7 2022-05-19))

ojeda · 2022-05-30T16:19:07Z

This is what you get when you run strings on rustc output that has debuginfo:

Yeah, that is DW_AT_producer; however sometimes the debug info may not be available (this came up as a possibility to know whether an object file came from C or Rust sources; with DWARF one may directly look into DW_AT_language instead for this purpose). It is also good to be consistent with the other compilers even if debug info is available in case some tooling looks for .comment.

tschuett · 2022-05-31T18:43:28Z

Maybe I missed the motivation for doing this:

consistency with clang and gcc
you have a use case: I need it for the linux kernel?
something else

bjorn3 · 2022-05-31T19:40:44Z

It is quite useful for easily figuring out which rustc version an executable was built with. This could for example be used to determine that it needs to be rebuilt if the rustc version it was built with has a CVE, but there are many more reasons to need which compiler version an executable was built with.

tschuett · 2022-05-31T19:48:11Z

That does indeed sound useful.

ojeda · 2022-05-31T20:03:07Z

consistency with clang and gcc

you have a use case: I need it for the linux kernel?

To clarify a bit on those two you mention:

Tooling (and/or users) may expect or take advantage of the .comment section (e.g. it would be one less difference between C and Rust object files in the kernel, there is the security monitoring point from @bjorn3, etc.).

Thus being consistent with GCC and Clang/LLVM is likely a good idea for those reasons (i.e. being consistent has other benefits; it is not just for the sake of consistency).
The kernel could use it (in principle) to distinguish C vs. Rust kernel modules when there is no debug info around. One can achieve the same in other ways, though.

I do not want to say "we need it", because we might end up not using it, but it would be nice to have for the other reasons.

Another point of view (not exactly a motivation, but related) is that one could argue it should be left up to the backend, e.g. if LLVM usually does it (when given the information), then it sounds reasonable to let it do it. rustc could still provide a way for users to opt-out that backends should respect. Maybe target specs could carry that info too. (cc @antoyo for GCC).

tschuett · 2022-06-01T20:11:07Z

Sorry. I believe consistency is it should be named .comment and not idk .version.

The real question is: is it helpful for rust users? I believe so.

nbdd0121 · 2022-06-04T20:04:56Z

Given that this is a public-facing change, a FCP is probably more appropriate?

bjorn3 · 2022-06-14T14:06:21Z

I don't have permission to start an fcp. Also should this be a compiler or lang team fcp?

bors · 2022-06-15T00:57:08Z

☔ The latest upstream changes (presumably #96285) made this pull request unmergeable. Please resolve the merge conflicts.

pnkfelix · 2022-07-21T14:47:45Z

Discussed in T-compiler meeting.

@rfcbot fcp merge

rfcbot · 2022-07-21T14:47:46Z

rfcbot · 2022-08-05T15:21:49Z

🔔 This is now entering its final comment period, as per the review above. 🔔

[RFC] Support `.comment` section like GCC/Clang (`!llvm.ident`) Both GCC and Clang write by default a `.comment` section with compiler information: ```txt $ gcc -c -xc /dev/null && readelf -p '.comment' null.o String dump of section '.comment': [ 1] GCC: (GNU) 11.2.0 $ clang -c -xc /dev/null && readelf -p '.comment' null.o String dump of section '.comment': [ 1] clang version 14.0.1 (https://github.com/llvm/llvm-project.git c62053979489ccb002efe411c3af059addcb5d7d) ``` They also implement the `-Qn` flag to avoid doing so: ```txt $ gcc -Qn -c -xc /dev/null && readelf -p '.comment' null.o readelf: Warning: Section '.comment' was not dumped because it does not exist! $ clang -Qn -c -xc /dev/null && readelf -p '.comment' null.o readelf: Warning: Section '.comment' was not dumped because it does not exist! ``` So far, `rustc` only does it for WebAssembly targets and only when debug info is enabled: ```txt $ echo 'fn main(){}' | rustc --target=wasm32-unknown-unknown --emit=llvm-ir -Cdebuginfo=2 - && grep llvm.ident rust_out.ll !llvm.ident = !{!27} ``` The RFC part of this PR is about which behavior should `rustc` follow: - Always add it. - Add it by default, i.e. have an opt-out flag (GCC, Clang). - Have an opt-in flag. - Never add it (current). There is also the question of whether debug info being enabled matters for that decision, given the current behavior of WebAssembly targets. For instance, adding it by default gets us closer to other popular compilers, but that may surprise some users with an information leak. The most conservative option is to only do so opt-in, even if debug info is enabled (some users may be stripping debug info and not expecting something else to be leaked elsewhere). Implementation-wise, this covers both `ModuleLlvm::new()` and `ModuleLlvm::new_metadata()` cases by moving the addition to `context::create_module` and adds a few test cases. ThinLTO also sees the `llvm.ident` named metadata duplicated (in temporary outputs), so this deduplicates it like it is done for `wasm.custom_sections`. The tests also check this duplication does not take place.

compiler-errors · 2023-01-21T02:31:17Z

@bors r- failed in rollup: #107134 (comment)

Dylan-DPC · 2023-05-13T17:38:48Z

@ojeda any updates on the failure?

cuviper

Setting the target should fix those test failures.

tests/run-make/comment-section/Makefile

tests/run-make/llvm-ident/Makefile

Both GCC and Clang write by default a `.comment` section with compiler information: ```txt $ gcc -c -xc /dev/null && readelf -p '.comment' null.o String dump of section '.comment': [ 1] GCC: (GNU) 11.2.0 $ clang -c -xc /dev/null && readelf -p '.comment' null.o String dump of section '.comment': [ 1] clang version 14.0.1 (https://github.com/llvm/llvm-project.git c62053979489ccb002efe411c3af059addcb5d7d) ``` They also implement the `-Qn` flag to avoid doing so: ```txt $ gcc -Qn -c -xc /dev/null && readelf -p '.comment' null.o readelf: Warning: Section '.comment' was not dumped because it does not exist! $ clang -Qn -c -xc /dev/null && readelf -p '.comment' null.o readelf: Warning: Section '.comment' was not dumped because it does not exist! ``` So far, `rustc` only does it for WebAssembly targets and only when debug info is enabled: ```txt $ echo 'fn main(){}' | rustc --target=wasm32-unknown-unknown --emit=llvm-ir -Cdebuginfo=2 - && grep llvm.ident rust_out.ll !llvm.ident = !{!27} ``` In the RFC part of this PR it was decided to always add the information, which gets us closer to other popular compilers. An opt-out flag like GCC and Clang may be added later on if deemed necessary. Implementation-wise, this covers both `ModuleLlvm::new()` and `ModuleLlvm::new_metadata()` cases by moving the addition to `context::create_module` and adds a few test cases. ThinLTO also sees the `llvm.ident` named metadata duplicated (in temporary outputs), so this deduplicates it like it is done for `wasm.custom_sections`. The tests also check this duplication does not take place. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

ojeda · 2023-07-21T20:05:52Z

Thanks @cuviper! I had this in the long backlog... The missing target makes sense.

Nowadays it seems almost all tests use ../tools.mk and are now in run-make (fulldeps means Rust internal crates/libs need to be available, right? So not the case here if I understand correctly).

Thus I rebased and updated the include too:

1:  ac4956b9c099 ! 1:  74b8d324eb77 Support `.comment` section like GCC/Clang (`!llvm.ident`)
    @@ compiler/rustc_codegen_llvm/src/context.rs: pub unsafe fn create_module<'ll>(
     
      ## compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs ##
     @@ compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs: pub fn build_compile_unit_di_node<'ll, 'tcx>(
    -             );
    +             llvm::LLVMAddNamedMetadataOperand(debug_context.llmod, llvm_gcov_ident.as_ptr(), val);
              }
      
     -        // Insert `llvm.ident` metadata on the wasm targets since that will
    @@ tests/codegen/llvm-ident.rs (new)
     
      ## tests/run-make/comment-section/Makefile (new) ##
     @@
    -+include ../../run-make-fulldeps/tools.mk
    ++include ../tools.mk
     +
     +# only-linux
     +
     +all:
    -+  echo 'fn main(){}' | $(RUSTC) - --emit=link,obj -Csave-temps
    ++  echo 'fn main(){}' | $(RUSTC) - --emit=link,obj -Csave-temps --target=$(TARGET)
     +
     +  # Check linked output has a `.comment` section with the expected content.
     +  readelf -p '.comment' $(TMPDIR)/rust_out | $(CGREP) -F 'rustc version 1.'
    @@ tests/run-make/comment-section/Makefile (new)
     
      ## tests/run-make/llvm-ident/Makefile (new) ##
     @@
    -+include ../../run-make-fulldeps/tools.mk
    ++include ../tools.mk
     +
     +# only-linux
     +
    @@ tests/run-make/llvm-ident/Makefile (new)
     +  # `-Ccodegen-units=16 -Copt-level=2` is used here to trigger thin LTO
     +  # across codegen units to test deduplication of the named metadata
     +  # (see `LLVMRustPrepareThinLTOImport` for details).
    -+  echo 'fn main(){}' | $(RUSTC) - --emit=link,obj -Csave-temps -Ccodegen-units=16 -Copt-level=2
    ++  echo 'fn main(){}' | $(RUSTC) - --emit=link,obj -Csave-temps -Ccodegen-units=16 -Copt-level=2 --target=$(TARGET)
     +
     +  # `llvm-dis` is used here since `--emit=llvm-ir` does not emit LLVM IR
     +  # for temporary outputs.

cuviper · 2023-07-21T20:38:02Z

Nowadays it seems almost all tests use ../tools.mk and are now in run-make (fulldeps means Rust internal crates/libs need to be available, right? So not the case here if I understand correctly).

Ah, yes, that was moved in #109770.

cuviper · 2023-07-21T20:39:46Z

I'll approve the relatively minor fixes, and pass the rest through:

@bors r=bjorn3

bors · 2023-07-21T20:39:48Z

📌 Commit 74b8d32 has been approved by bjorn3

It is now in the queue for this repository.

bors · 2023-07-21T21:17:29Z

⌛ Testing commit 74b8d32 with merge 0308df2...

bors · 2023-07-21T23:06:35Z

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing 0308df2 to master...

ojeda · 2023-07-21T23:53:39Z

Worked -- thanks for the quick delta-review @cuviper!

By the way, this could probably use a relnotes tag, to avoid surprises for users as noted in OP.

rust-timer · 2023-07-22T00:24:33Z

Finished benchmarking commit (0308df2): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.4%, 0.5%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.9%, -1.3%]	3
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.4%]	87
Regressions ❌ (secondary)	0.5%	[0.0%, 3.5%]	55
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.4%]	87

Bootstrap: 658.594s -> 659.657s (0.16%)

Language -------- - [Uplift `clippy::fn_null_check` lint as `useless_ptr_null_checks`.] (rust-lang/rust#111717) - [Make `noop_method_call` warn by default.] (rust-lang/rust#111916) - [Support interpolated block for `try` and `async` in macros.] (rust-lang/rust#112953) - [Make `unconditional_recursion` lint detect recursive drops.] (rust-lang/rust#113902) - [Future compatibility warning for some impls being incorrectly considered not overlapping.] (rust-lang/rust#114023) - [The `invalid_reference_casting` lint is now **deny-by-default** (instead of allow-by-default)] (rust-lang/rust#112431) Compiler -------- - [Write version information in a `.comment` section like GCC/Clang.] (rust-lang/rust#97550) - [Add documentation on v0 symbol mangling.] (rust-lang/rust#97571) - [Stabilize `extern "thiscall"` and `"thiscall-unwind"` ABIs.] (rust-lang/rust#114562) - [Only check outlives goals on impl compared to trait.] (rust-lang/rust#109356) - [Infer type in irrefutable slice patterns with fixed length as array.] (rust-lang/rust#113199) - [Discard default auto trait impls if explicit ones exist.] (rust-lang/rust#113312) - Add several new tier 3 targets: - [`aarch64-unknown-teeos`] (rust-lang/rust#113480) - [`csky-unknown-linux-gnuabiv2`] (rust-lang/rust#113658) - [`riscv64-linux-android`] (rust-lang/rust#112858) - [`riscv64gc-unknown-hermit`] (rust-lang/rust#114004) - [`x86_64-unikraft-linux-musl`] (rust-lang/rust#113411) - [`x86_64-unknown-linux-ohos`] (rust-lang/rust#113061) - [Add `wasm32-wasi-preview1-threads` as a tier 2 target.] (rust-lang/rust#112922) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Add `Read`, `Write` and `Seek` impls for `Arc<File>`.] (rust-lang/rust#94748) - [Merge functionality of `io::Sink` into `io::Empty`.] (rust-lang/rust#98154) - [Implement `RefUnwindSafe` for `Backtrace`] (rust-lang/rust#100455) - [Make `ExitStatus` implement `Default`] (rust-lang/rust#106425) - [`impl SliceIndex<str> for (Bound<usize>, Bound<usize>)`] (rust-lang/rust#111081) - [Change default panic handler message format.] (rust-lang/rust#112849) - [Cleaner `assert_eq!` & `assert_ne!` panic messages.] (rust-lang/rust#111071) - [Correct the (deprecated) Android `stat` struct definitions.] (rust-lang/rust#113130) Stabilized APIs --------------- - [Unsigned `{integer}::div_ceil`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.div_ceil) - [Unsigned `{integer}::next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.next_multiple_of) - [Unsigned `{integer}::checked_next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.checked_next_multiple_of) - [`std::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/std/ffi/struct.FromBytesUntilNulError.html) - [`std::os::unix::fs::chown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.chown.html) - [`std::os::unix::fs::fchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.fchown.html) - [`std::os::unix::fs::lfchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.lchown.html) - [`LocalKey::<Cell<T>>::get`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.get) - [`LocalKey::<Cell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set) - [`LocalKey::<Cell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take) - [`LocalKey::<Cell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace) - [`LocalKey::<RefCell<T>>::with_borrow`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow) - [`LocalKey::<RefCell<T>>::with_borrow_mut`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow_mut) - [`LocalKey::<RefCell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set-1) - [`LocalKey::<RefCell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take-1) - [`LocalKey::<RefCell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace-1) These APIs are now stable in const contexts: - [`rc::Weak::new`] (https://doc.rust-lang.org/stable/alloc/rc/struct.Weak.html#method.new) - [`sync::Weak::new`] (https://doc.rust-lang.org/stable/alloc/sync/struct.Weak.html#method.new) - [`NonNull::as_ref`] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.as_ref) Cargo ----- - [Encode URL params correctly for `SourceId` in `Cargo.lock`.] (rust-lang/cargo#12280) - [Bail out an error when using `cargo::` in custom build script.] (rust-lang/cargo#12332) Compatibility Notes ------------------- - [Update the minimum external LLVM to 15.] (rust-lang/rust#114148) - [Check for non-defining uses of return position `impl Trait`.] (rust-lang/rust#112842) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Remove LLVM pointee types, supporting only opaque pointers.] (rust-lang/rust#105545) - [Port PGO/LTO/BOLT optimized build pipeline to Rust.] (rust-lang/rust#112235) - [Replace in-tree `rustc_apfloat` with the new version of the crate.] (rust-lang/rust#113843) - [Update to LLVM 17.] (rust-lang/rust#114048) - [Add `internal_features` lint for internal unstable features.] (rust-lang/rust#108955) - [Mention style for new syntax in tracking issue template.] (rust-lang/rust#113586)

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. * For an external LLVM, set dependency of llvm >= 15, in accordance with the upstream changes. * Add a patch with a backport from LLVM 17.0.3 fixing codegen for PPC, ref. rust-lang/rust#116845 Upstream changes: Version 1.73.0 (2023-10-05) ========================== Language -------- - [Uplift `clippy::fn_null_check` lint as `useless_ptr_null_checks`.] (rust-lang/rust#111717) - [Make `noop_method_call` warn by default.] (rust-lang/rust#111916) - [Support interpolated block for `try` and `async` in macros.] (rust-lang/rust#112953) - [Make `unconditional_recursion` lint detect recursive drops.] (rust-lang/rust#113902) - [Future compatibility warning for some impls being incorrectly considered not overlapping.] (rust-lang/rust#114023) - [The `invalid_reference_casting` lint is now **deny-by-default** (instead of allow-by-default)] (rust-lang/rust#112431 Compiler -------- - [Write version information in a `.comment` section like GCC/Clang.] (rust-lang/rust#97550) - [Add documentation on v0 symbol mangling.] (rust-lang/rust#97571) - [Stabilize `extern "thiscall"` and `"thiscall-unwind"` ABIs.] (rust-lang/rust#114562) - [Only check outlives goals on impl compared to trait.] (rust-lang/rust#109356) - [Infer type in irrefutable slice patterns with fixed length as array.] (rust-lang/rust#113199) - [Discard default auto trait impls if explicit ones exist.] (rust-lang/rust#113312) - Add several new tier 3 targets: - [`aarch64-unknown-teeos`] (rust-lang/rust#113480) - [`csky-unknown-linux-gnuabiv2`] (rust-lang/rust#113658) - [`riscv64-linux-android`] (rust-lang/rust#112858) - [`riscv64gc-unknown-hermit`] (rust-lang/rust#114004) - [`x86_64-unikraft-linux-musl`] (rust-lang/rust#113411) - [`x86_64-unknown-linux-ohos`] (rust-lang/rust#113061) - [Add `wasm32-wasi-preview1-threads` as a tier 2 target.] (rust-lang/rust#112922) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Add `Read`, `Write` and `Seek` impls for `Arc<File>`.] (rust-lang/rust#94748) - [Merge functionality of `io::Sink` into `io::Empty`.] (rust-lang/rust#98154) - [Implement `RefUnwindSafe` for `Backtrace`] (rust-lang/rust#100455) - [Make `ExitStatus` implement `Default`] (rust-lang/rust#106425) - [`impl SliceIndex<str> for (Bound<usize>, Bound<usize>)`] (rust-lang/rust#111081) - [Change default panic handler message format.] (rust-lang/rust#112849) - [Cleaner `assert_eq!` & `assert_ne!` panic messages.] (rust-lang/rust#111071) - [Correct the (deprecated) Android `stat` struct definitions.] (rust-lang/rust#113130) Stabilized APIs --------------- - [Unsigned `{integer}::div_ceil`] (https://doc.rust-lang.org/stable/std/primitiv e.u32.html#method.div_ceil) - [Unsigned `{integer}::next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.next_multiple_of) - [Unsigned `{integer}::checked_next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.checked_next_multiple_of) - [`std::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/std/ffi/struct.FromBytesUntilNulError.html) - [`std::os::unix::fs::chown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.chown.html) - [`std::os::unix::fs::fchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.fchown.html) - [`std::os::unix::fs::lfchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.lchown.html) - [`LocalKey::<Cell<T>>::get`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.get) - [`LocalKey::<Cell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set) - [`LocalKey::<Cell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take) - [`LocalKey::<Cell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace) - [`LocalKey::<RefCell<T>>::with_borrow`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow) - [`LocalKey::<RefCell<T>>::with_borrow_mut`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow_mut) - [`LocalKey::<RefCell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set-1) - [`LocalKey::<RefCell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take-1) - [`LocalKey::<RefCell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace-1) These APIs are now stable in const contexts: - [`rc::Weak::new`] (https://doc.rust-lang.org/stable/alloc/rc/struct.Weak.html#method.new) - [`sync::Weak::new`] (https://doc.rust-lang.org/stable/alloc/sync/struct.Weak.html#method.new) - [`NonNull::as_ref`] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.as_ref) Cargo ----- - [Encode URL params correctly for `SourceId` in `Cargo.lock`.] (rust-lang/cargo#12280) - [Bail out an error when using `cargo::` in custom build script.] (rust-lang/cargo#12332) Misc ---- Compatibility Notes ------------------- - [Update the minimum external LLVM to 15.] (rust-lang/rust#114148) - [Check for non-defining uses of return position `impl Trait`.] (rust-lang/rust#112842) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Remove LLVM pointee types, supporting only opaque pointers.] (rust-lang/rust#105545) - [Port PGO/LTO/BOLT optimized build pipeline to Rust.] (rust-lang/rust#112235) - [Replace in-tree `rustc_apfloat` with the new version of the crate.] (rust-lang/rust#113843) - [Update to LLVM 17.] (rust-lang/rust#114048) - [Add `internal_features` lint for internal unstable features.] (rust-lang/rust#108955) - [Mention style for new syntax in tracking issue template.] (rust-lang/rust#113586)

rust-highfive assigned lcnr May 30, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 30, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2022

This comment has been minimized.

Sign in to view

ojeda force-pushed the comment-section branch from 1a6b1a3 to 48697f5 Compare May 30, 2022 14:37

rust-highfive assigned bjorn3 and unassigned lcnr May 30, 2022

ojeda force-pushed the comment-section branch from 48697f5 to d4fe95a Compare June 15, 2022 10:34

JohnCSimon added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Jul 3, 2022

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 21, 2022

compiler-errors mentioned this pull request Jan 20, 2023

Rollup of 8 pull requests #107132

Closed

matthiaskrgr mentioned this pull request Jan 20, 2023

Rollup of 10 pull requests #107134

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 21, 2023

cuviper reviewed Jul 21, 2023

View reviewed changes

tests/run-make/comment-section/Makefile Outdated Show resolved Hide resolved

tests/run-make/llvm-ident/Makefile Outdated Show resolved Hide resolved

ojeda force-pushed the comment-section branch from ac4956b to 7db3bba Compare July 21, 2023 19:45

ojeda force-pushed the comment-section branch from 7db3bba to 74b8d32 Compare July 21, 2023 20:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 21, 2023

bors merged commit 0308df2 into rust-lang:master Jul 21, 2023
12 checks passed

rustbot added this to the 1.73.0 milestone Jul 21, 2023

ojeda deleted the comment-section branch July 21, 2023 23:48

cuviper added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 21, 2023

ojeda mentioned this pull request Jan 19, 2024

rustc wanted features & bugfixes Rust-for-Linux/linux#355

Open

39 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC] Support `.comment` section like GCC/Clang (`!llvm.ident`) #97550

[RFC] Support `.comment` section like GCC/Clang (`!llvm.ident`) #97550

ojeda commented May 30, 2022 •

edited

rust-highfive commented May 30, 2022

This comment has been minimized.

bjorn3 commented May 30, 2022

ojeda commented May 30, 2022

lcnr commented May 30, 2022

ojeda commented May 30, 2022

ojeda commented May 30, 2022

est31 commented May 30, 2022

ojeda commented May 30, 2022 •

edited

tschuett commented May 31, 2022

bjorn3 commented May 31, 2022

tschuett commented May 31, 2022

ojeda commented May 31, 2022 •

edited

tschuett commented Jun 1, 2022

nbdd0121 commented Jun 4, 2022

bjorn3 commented Jun 14, 2022

bors commented Jun 15, 2022

pnkfelix commented Jul 21, 2022

rfcbot commented Jul 21, 2022 •

edited by Aaron1011

rfcbot commented Aug 5, 2022

compiler-errors commented Jan 21, 2023

Dylan-DPC commented May 13, 2023

cuviper left a comment

ojeda commented Jul 21, 2023 •

edited

cuviper commented Jul 21, 2023

cuviper commented Jul 21, 2023

bors commented Jul 21, 2023

bors commented Jul 21, 2023

bors commented Jul 21, 2023

ojeda commented Jul 21, 2023

rust-timer commented Jul 22, 2023

[RFC] Support .comment section like GCC/Clang (!llvm.ident) #97550

[RFC] Support .comment section like GCC/Clang (!llvm.ident) #97550

Conversation

ojeda commented May 30, 2022 • edited

rust-highfive commented May 30, 2022

This comment has been minimized.

bjorn3 commented May 30, 2022

ojeda commented May 30, 2022

lcnr commented May 30, 2022

ojeda commented May 30, 2022

ojeda commented May 30, 2022

est31 commented May 30, 2022

ojeda commented May 30, 2022 • edited

tschuett commented May 31, 2022

bjorn3 commented May 31, 2022

tschuett commented May 31, 2022

ojeda commented May 31, 2022 • edited

tschuett commented Jun 1, 2022

nbdd0121 commented Jun 4, 2022

bjorn3 commented Jun 14, 2022

bors commented Jun 15, 2022

pnkfelix commented Jul 21, 2022

rfcbot commented Jul 21, 2022 • edited by Aaron1011

rfcbot commented Aug 5, 2022

compiler-errors commented Jan 21, 2023

Dylan-DPC commented May 13, 2023

cuviper left a comment

Choose a reason for hiding this comment

ojeda commented Jul 21, 2023 • edited

cuviper commented Jul 21, 2023

cuviper commented Jul 21, 2023

bors commented Jul 21, 2023

bors commented Jul 21, 2023

bors commented Jul 21, 2023

ojeda commented Jul 21, 2023

rust-timer commented Jul 22, 2023

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

[RFC] Support `.comment` section like GCC/Clang (`!llvm.ident`) #97550

[RFC] Support `.comment` section like GCC/Clang (`!llvm.ident`) #97550

ojeda commented May 30, 2022 •

edited

ojeda commented May 30, 2022 •

edited

ojeda commented May 31, 2022 •

edited

rfcbot commented Jul 21, 2022 •

edited by Aaron1011

ojeda commented Jul 21, 2023 •

edited