Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ./x instead of ./x.py in documentation #1707

Closed
jyn514 opened this issue Jun 29, 2023 · 4 comments · Fixed by #1710
Closed

Use ./x instead of ./x.py in documentation #1707

jyn514 opened this issue Jun 29, 2023 · 4 comments · Fixed by #1710
Assignees
Labels
Easy Might be a good place for a beginner

Comments

@jyn514
Copy link
Member

jyn514 commented Jun 29, 2023

./x is the most likely to work on every system (on Unix it runs the shell script that does python version detection, on Windows it will probably run the powershell script - certainly less likely to break than ./x.py which often just opens the file in an editor).

This can be done with a simple find and replace, so it's a great first issue.

#1701 (comment)

@jyn514 jyn514 added the Easy Might be a good place for a beginner label Jun 29, 2023
@sslime336
Copy link
Contributor

@jyn514 Hi, I'd like to do this :-) but I also found that in nushell using vscode on Win10 that typing ./x still just open the x.py, which acts like below:

图片

If it's ok, I will also doc the exception which comes from myself

@sslime336
Copy link
Contributor

@rustbot claim

@jyn514
Copy link
Member Author

jyn514 commented Jun 30, 2023

sounds good :) yes unfortunately there's nothing that's going to work on every platform, but i think ./x has a better chance of working than ./x.py.

@JohnTitor
Copy link
Member

Addressed by #1710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Might be a good place for a beginner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants