Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various terms to the glossary #281

Merged
merged 6 commits into from Feb 18, 2019

Conversation

varkor
Copy link
Member

@varkor varkor commented Feb 16, 2019

I think this adds all the requested terms in #48 so far. They're a little short, but some context is better than none, and they can be extended in the future.

Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! r=me when travis is green

@mark-i-m mark-i-m mentioned this pull request Feb 18, 2019
27 tasks
@mark-i-m
Copy link
Member

cc @alexreg who had wanted some of these defs 😄

@mark-i-m mark-i-m merged commit de2ab38 into rust-lang:master Feb 18, 2019
@alexreg
Copy link
Contributor

alexreg commented Feb 18, 2019

Good work. A few things I would suggest:

  • memoise -> memoize, memoisation -> memoization (I'm British too, but I think US English is standard here).
  • Would it be helpful to distinguish early- and late-bound lifetimes in terms of "can bound at definition site" vs. "must be bound at call site"? This is how I understood it from the old blog post, and it resonated with me.

@varkor varkor deleted the glossary-additions branch February 18, 2019 22:56
@varkor
Copy link
Member Author

varkor commented Feb 18, 2019

  • Would it be helpful to distinguish early- and late-bound lifetimes in terms of "can bound at definition site" vs. "must be bound at call site"?

@alexreg: feel free to make those changes. I just thought I'd add something quickly, just to make sure there was something.

@alexreg
Copy link
Contributor

alexreg commented Feb 18, 2019

@varkor Okay ta. Just checking they make sense to you.

@mark-i-m
Copy link
Member

@alexreg A PR would be welcome (also lol, I'm America, and I like US English 😛 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants