Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConstEvalResult is now EvalToConstValueResult #885

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Sep 22, 2020

I believe this was changed in rust-lang/rust#74949, so r? @oli-obk

@LeSeulArtichaut
Copy link
Contributor

CI failure seems spurious, I just re-ran the checks

@camelid
Copy link
Member Author

camelid commented Sep 22, 2020

Yeah, it was due to 429 Too Many Requests to some sites. Is there any way to ignore 429 and related errors, and if so should we?

@LeSeulArtichaut LeSeulArtichaut merged commit 2a09b06 into rust-lang:master Sep 22, 2020
@camelid camelid deleted the update-mir-name branch September 22, 2020 20:52
@LeSeulArtichaut
Copy link
Contributor

Yeah, it was due to 429 Too Many Requests to some sites. Is there any way to ignore 429 and related errors, and if so should we?

I know there's been discussions about this in the past, not sure if we ever took a decision or not. I also know that we removed the rustc-dev-guide from toolstate because of these too

@camelid
Copy link
Member Author

camelid commented Sep 22, 2020

The README says:

Please note: You may receive errors like the following when link checks are active on local mdbook builds:

error: The server responded with 429 Too Many Requests for "https://github.com/rust-lang/rust/tree/master/src/tools/compiletest"
[...]

There is not a workaround for this error at the moment. Comment out the [output.linkcheck] field in the book.toml using the build instructions above to complete a local site build without link validations.

@camelid camelid mentioned this pull request Sep 22, 2020
@jyn514
Copy link
Member

jyn514 commented Sep 22, 2020

More discussion here: https://rust-lang.zulipchat.com/#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide/topic/move.20to.20gha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants