Split measurement of walltime and perf. counters #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnethercote
reviewed
Oct 13, 2022
nnethercote
reviewed
Oct 13, 2022
Kobzol
force-pushed
the
runtime-measurement-precision
branch
2 times, most recently
from
902eb15
to
2d156a1
Compare
|
You're right, we shouldn't add it without evidence that it helps. I have removed cache clearing from this PR and only kept the wall-time/perf. counter split. |
Kobzol
force-pushed
the
runtime-measurement-precision
branch
from
2d156a1
to
f173632
Compare
nnethercote
reviewed
Oct 13, 2022
nnethercote
reviewed
Oct 13, 2022
nnethercote
approved these changes
Oct 13, 2022
Kobzol
changed the title
Kobzol
force-pushed
the
runtime-measurement-precision
branch
from
f173632
to
c1bb6d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's all on a best effort basis.. maybe once we have the benchmarks running on perf.rlo we can do some experiments to see if this actually helps reduce variance.