Add comment about unifying types to Profile #1518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @nnethercote here.
I didn't add the same comment to
Scenario
, as it would be mostly duplicated (and scenario is not so similar in the DB, so people probably won't be inclined to try to merge it).I added the note as a regular comment, as it's just an implementation note and shouldn't appear in rustdoc (not that many people look at docs of
rustc-perf
I suppose :) ).