Generalize site pstat querying for runtime benchmarks
#1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Postgres implementation performs a single query, therefore it shouldn't require a transaction
Kobzol
force-pushed
the
runtime-site-backend
branch
from
096a4dc
to
a665929
Compare
Kobzol
commented
Jun 11, 2023
Mark-Simulacrum
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the
sitebenchmark data querying code to also make runtime benchmark data available. The generalization is now based on test cases - for compile benchmarks we have each benchmark parametrized by(benchmark, profile, scenario), for runtime benchmarks it's currently only(benchmark, ).To make it work on CI, this PR also implements support for runtime benchmarks for the Postgres DB backend.
Best reviewed commit by commit.