Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command to profile a runtime benchmark #1691

Merged
merged 5 commits into from Aug 7, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Aug 6, 2023

This PR adds a CLI command for profiling a single runtime benchmark. Currently, running a single benchmark function under cachegrind is supported. Later, I want to make the cachegrind profiling more precise with cachegrind client requests that would only profile the part of the benchmark group where the benchmark function actually runs (so without initialization, CLI parsing,e tc.). I also want to add cachegrind diff functionality in a followup PR to compare instructions executed by a runtime benchmark compiled by two different compiler versions.

I named the command just profile_runtime instead of profile_local_runtime. Profiling of "remote" artifacts doesn't really make sense, so I think that profile_local should also be renamed to profile_compile or something like that.

@Kobzol Kobzol requested a review from nnethercote August 6, 2023 13:44
@Kobzol Kobzol force-pushed the runtime-benchmark-profile branch 2 times, most recently from 890d76c to ea20364 Compare August 6, 2023 14:05
@Kobzol Kobzol enabled auto-merge August 7, 2023 09:19
@Kobzol Kobzol merged commit 0635724 into rust-lang:master Aug 7, 2023
9 checks passed
@Kobzol Kobzol deleted the runtime-benchmark-profile branch August 7, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants