normalize_symbol_name: also strip numeric suffix #1859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some symbols also have a numeric suffix, e.g. in
<core::fmt::Error as core::fmt::Debug>::fmt::h863044c0549d7049.60
.This results in spurious diffs, e.g. when running
./target/release/collector binary_stats +6f3eb1ce3d50246b2cbc5de3107c0f34889f5cc6 --rustc2 +2105ceeb0f23267f160392bd0e43b1c647590aac --include helloworld-tiny --profile Opt --backend Llvm --symbols
, I see:Similar to #1843