Add triage-2021-02-24 #844
Conversation
triage/2021-02-24.md
Outdated
|
|
||
| Inline try_get_cached [#82197](https://github.com/rust-lang/rust/issues/82197) | ||
| - Very large improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=8fe989dd768f5dfdb0fc90933f3f74fa4579fefd&end=ee88f46bb5e27c4d9f30326e69ff2298dcbeecb1&stat=instructions:u) (up to -10.4% on `full` builds of `externs-debug`) | ||
| - An attempt to fix an issue due to a bad interaction with [#81892](https://github.com/rust-lang/rust/issues/81892) which removed a bunch of largely unnecessary inline directives. |
There was a problem hiding this comment.
Should the formulation attribute the improvement to the three PRs ? rust-lang/rust#82197 , rust-lang/rust#81892 and rust-lang/rust#81855
There was a problem hiding this comment.
The improvement itself is just from what was measured after the merging of rust-lang/rust#82197, but I can reference rust-lang/rust#81855 if you'd like.
There was a problem hiding this comment.
The changes from rust-lang/rust#81855 are directly responsible for the improvement. I would appreciate if you could emphasize that. I would feel uncomfortable if the improvements were to be attributed to rust-lang/rust#82197 which merely added an inline hint to fix unintended interaction with rust-lang/rust#81892, which landed in the meantime. Thanks.
There was a problem hiding this comment.
I would describe it as:
rust-lang/rust#82197 shows improvements originally expected from rust-lang/rust#81855, which based query fast path on
try_get_cached. In-between the initial successful perf run of rust-lang/rust#81855 and merging, another PR rust-lang/rust#81892 removed an inline hint from the function, which was soon to be on the fast path.
rylev
force-pushed
the
triage-2021-02-24
branch
from
a90a609
to
786b6e4
Compare
No description provided.