Use crates.io releases of Cranelift #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I originally switched the Cranelift dependencies to use git as cg_clif required a lot of new Cranelift features. With crates.io dependencies I would have to wait for a new release every time. With git dependencies I could start using the new features as soon as they were merged. Currently there aren't a lot of new Cranelift features necessary anymore and those that are useful are no longer blocking compilation of lots of crates. There was some concern expressed about using git dependencies in the main rust repo, so all together I think it is best to switch to crates.io releases and if necessary wait a bit before merging changes requiring newer Cranelift commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally switched the Cranelift dependencies to use git as cg_clif required a lot of new Cranelift features. With crates.io dependencies I would have to wait for a new release every time. With git dependencies I could start using the new features as soon as they were merged. Currently there aren't a lot of new Cranelift features necessary anymore and those that are useful are no longer blocking compilation of lots of crates. There was some concern expressed about using git dependencies in the main rust repo, so all together I think it is best to switch to crates.io releases and if necessary wait a bit before merging changes requiring newer Cranelift commits.
There is still a git dependency on my fork of the ar crate (https://github.com/bjorn3/rust-ar/tree/do_not_remove_cg_clif_ranlib). I think I will need to fix symbol table support for macOS and then poke the maintainer of rust-ar to release a new version of my PR.
cc rust-lang/rust#81746 (comment), @Mark-Simulacrum