Support compiling codegen units in parallel #1271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this on machines with many cores cg_llvm no longer has a perf advantage over cg_clif on the simple-raytracer benchmark:
And even on my personal laptop there is a non-trivial perf improvement (~35% perf benefit of cg_clif over cg_llvm as opposed to ~20% previously):
On the rustc perf suite there are now only a couple of wall time regressions compared to cg_llvm as opposed to almost all.
Wall time on the rustc perf suite when compared to cg_llvm.
The jobserver handling could probably be finetuned for a bit more performance, but as I have been struggling with getting it to work correctly at all for almost a week, I'm going to leave that for now.
Fixes #652
See #1266 for the previous PR in this series.