Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows CI #1284

Merged
merged 11 commits into from
Sep 27, 2022
Merged

Add Windows CI #1284

merged 11 commits into from
Sep 27, 2022

Conversation

afonso360
Copy link
Contributor

@afonso360 afonso360 commented Sep 27, 2022

馃憢 Hey,

With the upgrade to Cranelift 0.88 we can now enable MSVC in the build script and add some CI. This also adds CI for MinGW on Windows, which I didn't expect to hit so many issues, but it turns out MinGW is even more broken than I thought.

A summary of issues / tests disabled:

  • The JIT is still broken, so we disable all JIT tagged tests on windows
  • bench.simple-raytracer
    • This is disabled due to hyperfine failing with an invalid preparation command
      Its just a build system issue.
  • test.regex-shootout-regex-dna
    • This fails with a different output than expected
      The actual file is mostly the same, I think this is just different line endings
  • abi-cafe patch
    • We've dropped the previous patch, in favour of the default config for disabling the i128 windows abi issues
      But it looks like its not broad enough since x86_64-pc-windows-gnu still fails, so we temporarily disable those
      I'm going to follow up with abi-cafe to disable those tests on MinGW as well
  • rand patch
    • There are a bunch of tests failing on rand, these only affect x86_64-pc-windows-gnu presumably due to some broken implementations on the MinGW side? I haven't investigated this too far.

cc #977

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
Copy link
Member

@bjorn3 bjorn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will merge once CI passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants