Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish latest build as release #1365

Merged
merged 6 commits into from
Mar 25, 2023
Merged

Publish latest build as release #1365

merged 6 commits into from
Mar 25, 2023

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Mar 24, 2023

This is easier to find than artifacts from the CI page and allows downloads without logging in. It also ensures that if I push a broken commit to the master branch people can still find the latest version that passes all tests.

I am still working on making cg_clif distributed with rustup, but until that is done this should be useful for people.

Closes #1337
cc #1349 (comment)

@bjorn3
Copy link
Member Author

bjorn3 commented Mar 24, 2023

For anyone who saw the current release at https://github.com/bjorn3/rustc_codegen_cranelift/releases/tag/dev, this was a test release to test if everything works. By the way did you get a notification every time or only for the first time a release was created under the dev tag?

@bjorn3
Copy link
Member Author

bjorn3 commented Mar 24, 2023

cc @frederikhors, @peter-kehl

@eggyal
Copy link
Contributor

eggyal commented Mar 24, 2023

I received a notification the first time, but not since. Has there been a second?

@frederikhors
Copy link

I was on this unfortunately, so I missed it.

image

I'm glad to help from now. Tell me what do you want to know.

@frederikhors
Copy link

Now I'm on this instead:

image

@eggyal
Copy link
Contributor

eggyal commented Mar 24, 2023

FWIW I've been on "all activity" throughout.

image

@bjorn3
Copy link
Member Author

bjorn3 commented Mar 24, 2023

Maybe to get a notification every time I did have to delete and recreate the release in the release action?

@frederikhors
Copy link

frederikhors commented Mar 24, 2023

Maybe to get a notification every time I did have to delete and recreate the release in the release action?

I do not understand. Can we try right now?

I'm here for you.

@bjorn3
Copy link
Member Author

bjorn3 commented Mar 24, 2023

I can't test it right now as I'm on my phone. I can write the code to delete the release before creating it tomorrow and then trigger a CI run for it.

@frederikhors
Copy link

Ok. I'm here for you.

@bjorn3 bjorn3 force-pushed the dev-release branch 2 times, most recently from 59d5e45 to b2b749c Compare March 25, 2023 15:57
@eggyal
Copy link
Contributor

eggyal commented Mar 25, 2023

Received a release notification.

@frederikhors
Copy link

Received a release notification.

Me too.

@frederikhors
Copy link

frederikhors commented Mar 25, 2023

Another one now.

image

@bjorn3
Copy link
Member Author

bjorn3 commented Mar 25, 2023

Got a notification for both releases in the github ui too. And it looks like the first notification is entirely gone after the second release, so it won't clobber the notification list if I push multiple times in a row.

To ensure people who watch the repo for release notifications actually get a
notification.
@frederikhors
Copy link

@bjorn3 I just received these two releases notifications emails, is that correct?

  • the first:
    image

  • the second:
    image

@bjorn3
Copy link
Member Author

bjorn3 commented Mar 26, 2023

Yes, I first merged a PR and a bit later pushed another commit directly to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider enabling "Releases" on GitHub
3 participants