Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly import foreign statics #115

Merged
merged 2 commits into from Jan 25, 2022
Merged

Correctly import foreign statics #115

merged 2 commits into from Jan 25, 2022

Commits on Jan 25, 2022

  1. Correctly import foreign statics 

    Previously foreign statics would actually cause a local static to be
defined and exported. This issue was found because std::env::vars() was
found to return no env vars despite many being defined. This was caused
by libstd importing environ as foreign static. The accidental definition
of environ caused libstd to read a null pointer which was interpreted as
there being no environment variables at all.

Also fix tests. STDOUT is not defined by libc. The correct name is stdout.
This previously worked as STDOUT was incorrectly defined as null pointer
during codegen.
    @bjorn3
    bjorn3 committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    cd5d42a View commit details
    Browse the repository at this point in the history

  2. Move rustup component installation to rust-toolchain 

    This allows cargo check to function correctly without having to first
run prepare_build.sh. cg_clif has been using rust-toolchain too for a
while now.
    @bjorn3
    bjorn3 committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    6663f4e View commit details
    Browse the repository at this point in the history