Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass --target in cargo.sh #147

Merged
merged 1 commit into from Mar 26, 2022
Merged

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Mar 26, 2022

This was a workaround for compiling proc macros resulting in an abi
incompatibility. By passing --target proc macros will be built by the
llvm backend. This is no longer necessary as the abi incompatibility has
since been fixed.

This was a workaround for compiling proc macros resulting in an abi
incompatibility. By passing --target proc macros will be built by the
llvm backend. This is no longer necessary as the abi incompatibility has
since been fixed.
@bjorn3
Copy link
Member Author

bjorn3 commented Mar 26, 2022

On further thought this will regress error messages when proc macros panic as proc macros will now be built with -Cpanic=abort. See rust-lang/rustc_codegen_cranelift#1174. @antoyo I will let it up to you if you want to merge this before implementing unwinding or if you want to wait on this.

@antoyo
Copy link
Contributor

antoyo commented Mar 26, 2022

I'm ok with merging this without unwinding support.

@antoyo antoyo merged commit 14c33f5 into rust-lang:master Mar 26, 2022
@bjorn3 bjorn3 deleted the misc_improvements branch March 26, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants