Implement prefetch data intrinsics #420
Open
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do you know what kind of tests there is for this in the LLVM codegen? |
|
The codegen tests are probably the most thorough, but they are LLVM specific. However, according to the FileCheck documentation, it doesn't do much that can't be done with grep. At a minimum though, I think we should check that the compiler can encounter the function without panicking. |
I would be OK with such a test. You can add it in this directory. |
|
Is this still a draft or should I review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414
It should probably have tests that should fail before the changes. What kind of test should I add?
I edited the builtin list in context.rs, and that might create a conflict when syncing with the rust repository.