Skip to content

Commit

Permalink
Support non-lifetime binders
Browse files Browse the repository at this point in the history
  • Loading branch information
compiler-errors committed Jul 19, 2023
1 parent c6d39a2 commit 6614042
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 12 deletions.
4 changes: 2 additions & 2 deletions src/closures.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use crate::overflow::OverflowableItem;
use crate::rewrite::{Rewrite, RewriteContext};
use crate::shape::Shape;
use crate::source_map::SpanUtils;
use crate::types::rewrite_lifetime_param;
use crate::types::rewrite_bound_params;
use crate::utils::{last_line_width, left_most_sub_expr, stmt_expr, NodeIdExt};

// This module is pretty messy because of the rules around closures and blocks:
Expand Down Expand Up @@ -246,7 +246,7 @@ fn rewrite_closure_fn_decl(
"for<> ".to_owned()
}
ast::ClosureBinder::For { generic_params, .. } => {
let lifetime_str = rewrite_lifetime_param(context, shape, generic_params)?;
let lifetime_str = rewrite_bound_params(context, shape, generic_params)?;
format!("for<{lifetime_str}> ")
}
ast::ClosureBinder::NotPresent => "".to_owned(),
Expand Down
17 changes: 7 additions & 10 deletions src/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -426,10 +426,10 @@ impl Rewrite for ast::WherePredicate {
}) => {
let type_str = bounded_ty.rewrite(context, shape)?;
let colon = type_bound_colon(context).trim_end();
let lhs = if let Some(lifetime_str) =
rewrite_lifetime_param(context, shape, bound_generic_params)
let lhs = if let Some(binder_str) =
rewrite_bound_params(context, shape, bound_generic_params)
{
format!("for<{}> {}{}", lifetime_str, type_str, colon)
format!("for<{}> {}{}", binder_str, type_str, colon)
} else {
format!("{}{}", type_str, colon)
};
Expand Down Expand Up @@ -657,8 +657,7 @@ impl Rewrite for ast::GenericParam {

impl Rewrite for ast::PolyTraitRef {
fn rewrite(&self, context: &RewriteContext<'_>, shape: Shape) -> Option<String> {
if let Some(lifetime_str) =
rewrite_lifetime_param(context, shape, &self.bound_generic_params)
if let Some(lifetime_str) = rewrite_bound_params(context, shape, &self.bound_generic_params)
{
// 6 is "for<> ".len()
let extra_offset = lifetime_str.len() + 6;
Expand Down Expand Up @@ -881,8 +880,7 @@ fn rewrite_bare_fn(

let mut result = String::with_capacity(128);

if let Some(ref lifetime_str) = rewrite_lifetime_param(context, shape, &bare_fn.generic_params)
{
if let Some(ref lifetime_str) = rewrite_bound_params(context, shape, &bare_fn.generic_params) {
result.push_str("for<");
// 6 = "for<> ".len(), 4 = "for<".
// This doesn't work out so nicely for multiline situation with lots of
Expand Down Expand Up @@ -1123,15 +1121,14 @@ pub(crate) fn can_be_overflowed_type(
}

/// Returns `None` if there is no `LifetimeDef` in the given generic parameters.
pub(crate) fn rewrite_lifetime_param(
pub(crate) fn rewrite_bound_params(
context: &RewriteContext<'_>,
shape: Shape,
generic_params: &[ast::GenericParam],
) -> Option<String> {
let result = generic_params
.iter()
.filter(|p| matches!(p.kind, ast::GenericParamKind::Lifetime))
.map(|lt| lt.rewrite(context, shape))
.map(|param| param.rewrite(context, shape))
.collect::<Option<Vec<_>>>()?
.join(", ");
if result.is_empty() {
Expand Down
10 changes: 10 additions & 0 deletions tests/source/non-lifetime-binders.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
fn main() where for<'a, T: Sized + 'a, const C: usize> [&'a T; C]: Sized {
let x = for<T>
|| {};

let y: dyn
for<T> Into<T>;

let z: for<T>
fn(T);
}
10 changes: 10 additions & 0 deletions tests/target/non-lifetime-binders.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
fn main()
where
for<'a, T: Sized + 'a, const C: usize> [&'a T; C]: Sized,
{
let x = for<T> || {};

let y: dyn for<T> Into<T>;

let z: for<T> fn(T);
}

0 comments on commit 6614042

Please sign in to comment.