-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[unstable option] overflow_delimited_expr #3370
Comments
I feel like this could also apply to function calls in the tail argument, rewriting market.open_order(
upos,
Order::limit(
market.pair().clone(),
direction,
price,
amount,
self.user_id,
),
)?; to market.open_order(upos, Order::limit(
market.pair().clone(),
direction,
price,
amount,
self.user_id,
))?; This would allow for symmetry between structs instantiated via their constructor and constructor methods. What do you think? |
Why is this unstable and what needs to be done to stabilize it? Any options that reduce unnecessary indentation are wonderful IMO |
When new config options are added to rustfmt, they are almost always added as unstable options. I'm not sure whether there are any outstanding items with this particular option, but it could actually be ready for stabilization: it's entirely possible that like many of the other currently-unstable options that it's only unstable because it hasn't been stablized yet.
The process for stablizing a config option is documented here: https://github.com/rust-lang/rustfmt/blob/master/Processes.md#stabilising-an-option If indeed the enumerated stabilzation conditions are true for this option, then the act of stabilizing would involve changing:
to: overflow_delimited_expr: bool, false, true, And then updating the stable flag in the configuration docs |
I should have looked around a bit more to save you the trouble, but thanks for answering! Considering the conditions:
I'll have to look into 2 and 3. The only trouble I see now is that I think the default is incorrect. I'd propose to change it to have a version-gate as outlined here and make it enabled by default in future versions, should it be stabilized. I've made a comment asking why not here: rust-lang/style-team#61 (comment) I'll make a PR for whatever is necessary to stabilize this option pending the conclusion of that discussion. |
@pitaj Thank you for bringing this up. We will review this option once again, and if it looks good, we will change the default value and stabilize it in the next release. |
I'd like to see similar option for string literals, e.g. gen!(f, "
trait $trait_name {
fn $func_name(self, $args_sig);
}
")?; Should that be configured separately, or in the same option? In my case I can skip the macro, but it might be useful in other cases. |
The current implementation of this option produces strange output when the last value is a struct, and overflowing causes the line to exceed For example, in this diff I think breaking after the Alternatively, changing it to a tri-valued string would be fine. let mut channel = FakeChannel::new();
- let encoder = ResponseEncoder::new(
- &mut channel,
- REQUEST_ID,
- crate::Version { major: 7, minor: 9 },
- );
+ let encoder =
+ ResponseEncoder::new(&mut channel, REQUEST_ID, crate::Version {
+ major: 7,
+ minor: 9,
+ });
resp.encode_response(encoder).unwrap(); |
Hi, is it possible to apply this option to handle_broken_pipe(
try {
serde_json::to_writer(&mut stdout, &out_msg)?;
stdout.write_all(b"\n")?;
},
)
.context("Failed to serialize to stdout")?; And if this option was applied to them, then I'd expect the output to be as follows: handle_broken_pipe(try {
serde_json::to_writer(&mut stdout, &out_msg)?;
stdout.write_all(b"\n")?;
})
.context("Failed to serialize to stdout")?; |
Hello, is it possible to change this behavior with nested arrays? vbuf.write(i * 3, &[
[h - 0.1, v, 0.0],
[h + 0.1, v, 0.0],
[h, v + 0.1, 0.0],
]); to vbuf.write(i * 3, &[[h - 0.1, v, 0.0], [h + 0.1, v, 0.0], [
h,
v + 0.1,
0.0,
]]); which isn't really desirable. Consider always forcing arrays onto the next line if they would wrap at all, like the first example. |
Tracking issue for unstable option: overflow_delimited_expr
The text was updated successfully, but these errors were encountered: