Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build rustfmt for wasm32-unknown-unknown #4845

Closed
thomaseizinger opened this issue May 21, 2021 · 2 comments
Closed

Build rustfmt for wasm32-unknown-unknown #4845

thomaseizinger opened this issue May 21, 2021 · 2 comments

Comments

@thomaseizinger
Copy link
Contributor

Recently, rustfmt changed from depending on rustc-ap-* crates to depend on the rustc-dev component instead. I assume this makes rustfmt development a lot easier because you no longer need to sync crate versions with the nightly compiler you are using.

Unfortunately though, rustc-dev is not available for wasm: https://rust-lang.github.io/rustup-components-history/wasm32-unknown-unknown.html
I've never heard of rustc-dev before but the rustup documentation states that it is the entire compiler as a library: https://rust-lang.github.io/rustup/concepts/components.html

I am not sure where to ask for this but is there any chance rustc-dev will be available for the wasm32-unknown-unknown target so that rustfmt can be compiled to wasm again?

@thomaseizinger thomaseizinger changed the title Build rustfmt for wasm32-unknown-unknown Build rustfmt for wasm32-unknown-unknown May 21, 2021
@calebcartwright
Copy link
Member

I am not sure where to ask for this but is there any chance rustc-dev will be available for the wasm32-unknown-unknown target

I'm not sure if that's feasible/what it would take to make that happen. In general questions about those components should be directed to https://github.com/rust-lang/rust, though perhaps someone from @rust-lang/infra could answer or move this issue to the r-l/rust repo for you

I assume this makes rustfmt development a lot easier because you no longer need to sync crate versions with the nightly compiler you are using.

The change is not about the development of rustfmt. It's about the strategy relative to the auto publish crates/the goal to remove our dogfooding of those crates within the shipped tools, as well as ensuring a better end user experience for the entire community of rustfmt users as we'd discussed over in #4343.

Sorry to hear this change caused some challenges for you all, but seems like a good opportunity to reconsider some of those alternative options for consuming/utilizing rustfmt.

@thomaseizinger
Copy link
Contributor Author

Opened a follow-up issue here: rust-lang/rust#86122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants