Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustfmt diff is reversed #606

Closed
sanxiyn opened this issue Nov 15, 2015 · 2 comments
Closed

rustfmt diff is reversed #606

sanxiyn opened this issue Nov 15, 2015 · 2 comments

Comments

@sanxiyn
Copy link
Member

sanxiyn commented Nov 15, 2015

Normally, diff prints - lines first and then + lines, but rustfmt diff prints + lines first and then - lines.
@utkarshkukreti utkarshkukreti mentioned this issue Dec 25, 2015
Closed
@utkarshkukreti
Copy link
Contributor

@sanxiyn this should be fixed now with diff#0.1.8. Please reinstall rustfmt (or delete Cargo.lock and recompile) and confirm whenever you have time :)

@marcusklaas
Copy link
Contributor

I think we should bump the version of diff in our lock file before we close this.

utkarshkukreti added a commit to utkarshkukreti/rustfmt that referenced this issue Dec 28, 2015
@utkarshkukreti
Bump diff to 0.1.8. Fixes rust-lang#606.
2d4037c
utkarshkukreti added a commit to utkarshkukreti/rustfmt that referenced this issue Dec 28, 2015
@utkarshkukreti
Bump diff to 0.1.8. Fixes rust-lang#606.
6a12818
utkarshkukreti added a commit to utkarshkukreti/rustfmt that referenced this issue Dec 28, 2015
@utkarshkukreti
Add tests for rust-lang#606.
15e6b7d
@utkarshkukreti utkarshkukreti mentioned this issue Dec 28, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sanxiyn @utkarshkukreti @marcusklaas