Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep leading colons for global paths #3293

Merged
merged 3 commits into from Jan 27, 2019
Merged

Keep leading colons for global paths #3293

merged 3 commits into from Jan 27, 2019

Conversation

scampi
Copy link
Contributor

@scampi scampi commented Jan 22, 2019

Close #3241

@scampi
Copy link
Contributor Author

scampi commented Jan 23, 2019

tests fail on failure and rust-clippy at compile-time, before running rustfmt.

@topecongiro
Copy link
Contributor

Thanks for the PR! Could you add some test to clarify what this PR is trying to fix please? Also AFAICT even with this PR, rustfmt still removes the leading :: when the imports are list or glob (e.g. use ::{foo, bar}; or use ::*;).

@scampi
Copy link
Contributor Author

scampi commented Jan 27, 2019

@topecongiro Thanks for the review, please have a look again.

@topecongiro
Copy link
Contributor

Thanks for the update! LGTM.

@topecongiro topecongiro merged commit 36c9dc6 into rust-lang:master Jan 27, 2019
@scampi scampi deleted the issue-3241 branch January 27, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scampi @topecongiro