Add cargo-make support #4191
Add cargo-make support #4191
Conversation
|
Good catch on the relative paths in the old cargo config 🤦♂️ It's surprising to see the Windows jobs failing, and I don't see anything in the cargo make config that explains it |
| @@ -39,13 +39,15 @@ jobs: | |||
| override: true | |||
| profile: minimal | |||
| default: true | |||
|
|
|||
| - name: cargo-make | |||
| run: cargo install --force cargo-make | |||
There was a problem hiding this comment.
Probably worth trying the GitHub Actions (https://github.com/sagiegurari/cargo-make#usage-ci-github-actions or https://github.com/marketplace/actions/rust-cargo-make) approach for grabbing cargo-make to see if that speeds things up
There was a problem hiding this comment.
Thanks for the advice! I have added rustc-cargo-make action.
There was a problem hiding this comment.
Hmm, unfortunately, it looks like the rustc-cargo-make does not pick up the latest cargo-make even when told to do so 🤔 I will just use cargo install approach for now.
| [tasks.test-subproject] | ||
| condition = { env_set = ["RUSTFMT_MAKE_MANIFEST_PATH"] } | ||
| script = [ | ||
| "cargo test --manifest-path ${RUSTFMT_MAKE_MANIFEST_PATH}", |
There was a problem hiding this comment.
seems the Windows jobs aren't substituting here though seems right to me based on a cursory reading of the cargo make docs
There was a problem hiding this comment.
Looks like we need to change script_runner on windows: sagiegurari/cargo-make#62.
|
Great, finally it's green 🥺 |
|
backport not needed |
karyon
added
1x-backport:completed
1x-backport:n/a
and removed
1x-backport:completed
labels
This PR adds support for cargo-make to ease the development of rustfmt. Also, I removed .cargo/config file as it was not working as intended when we run
cargocommand in subdirectories.