Fix static async closure qualifier order #5150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
approved these changes
Dec 24, 2021
There was a problem hiding this comment.
LGTM, thanks for the report and fix.
I'm a bit surprised by the presence of this issue given the age of the corresponding code (though admittedly never had a use case where I personally needed this so not sure how prevalent it may be). Do you know if something has happened to change upstream or have we just been sitting on a ~4 year old bug?
|
I don't know of anything changing recently. I just hit this while writing pretty printer tests in rust-lang/rust#92238. Rustfmt was mangling the tests: https://github.com/rust-lang/rust/blob/55fc986be72c0db77b65b0198ed5b26ac918ddad/src/test/ui/macros/stringify.rs#L216-L225. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5149.
Previously rustfmt would produce
async static || ...which is not valid syntax. The ordering that rustc accepts isstatic async || ....