Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve attributes for imports_granularity=Item #5314

Merged
merged 3 commits into from Apr 17, 2022
Merged

Preserve attributes for imports_granularity=Item #5314

merged 3 commits into from Apr 17, 2022

Conversation

tommilligan
Copy link
Contributor

Driving #5031 to completion - the original PR has been stale for a month, so I have:

  • rebased on master
  • applied the outstanding feedback
  • added an additional test case (happy to add more if required)

Will squash once ready for merge.

@tommilligan tommilligan mentioned this pull request Apr 16, 2022
Closed
calebcartwright
calebcartwright approved these changes Apr 17, 2022
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will be good to get this over the finish line!

@calebcartwright calebcartwright merged commit acdab00 into rust-lang:master Apr 17, 2022
@calebcartwright calebcartwright mentioned this pull request Apr 17, 2022
Closed
@calebcartwright calebcartwright added the release-notes Needs an associated changelog entry label Apr 17, 2022
@tommilligan tommilligan deleted the preserve-attrs-in-imports-granularity-item branch April 17, 2022 18:22
@narpfel
Copy link
Contributor

narpfel commented Apr 17, 2022

Thanks a lot!

@calebcartwright calebcartwright removed the release-notes Needs an associated changelog entry label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tommilligan @narpfel @calebcartwright