Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite float literals ending in dots with parens in method calls #5794

Merged
merged 1 commit into from Jul 3, 2023
Merged

Rewrite float literals ending in dots with parens in method calls #5794

merged 1 commit into from Jul 3, 2023

Conversation

fee1-dead
Copy link
Member

Fixes #5791

calebcartwright
calebcartwright approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty!

going to hold off a bit on merging this and others until after we get the let-else stuff synced though

@calebcartwright calebcartwright added release-notes Needs an associated changelog entry and removed pr-ready-to-merge labels Jul 3, 2023
@calebcartwright calebcartwright merged commit bb87a1b into rust-lang:master Jul 3, 2023
27 checks passed
@ytmimi ytmimi removed the release-notes Needs an associated changelog entry label Oct 23, 2023
@ytmimi ytmimi mentioned this pull request Oct 27, 2023
Open
@fee1-dead fee1-dead deleted the rewrite-float-lit-with-parens branch February 22, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method call on 0. float literals formats to incorrect code
3 participants
@fee1-dead @calebcartwright @ytmimi