Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix windows installation instructions #1729

Merged
merged 1 commit into from Oct 18, 2023

Conversation

VeeDeltaVee
Copy link
Contributor

Currently, the windows installation instructions download a script from the URL ps1.rustlings.cool. This URL isn't detected as a URL in some cases, which means that PowerShell tries to load the data from a local file called ps1.rustlings.cool.

This was breaking my install, and adding the https:// fixed it.

Currently, the windows installation instructions download a script from the URL ps1.rustlings.cool. This URL isn't detected as a URL in some cases, which means that PowerShell tries to load the data from a local file called ps1.rustlings.cool.

This was breaking my install, and adding the https:// fixed it.
Copy link
Member

@shadows-withal shadows-withal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@shadows-withal shadows-withal merged commit 0d65d17 into rust-lang:main Oct 18, 2023
5 checks passed
@shadows-withal
Copy link
Member

@all-contributors please add @VeeDeltaVee for docs

@allcontributors
Copy link
Contributor

@shadows-withal

I've put up a pull request to add @VeeDeltaVee! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants