Reading the info.toml file
#1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the
tomlcrate withtoml_edit. Thetomlcrate usestoml_editunder the hood anyway (see https://epage.github.io/blog/2023/01/toml-vs-toml-edit by the author of both crates).There is one change caused by this move: The
displayfeature oftoml_editis not enabled now which means that we only activate what we use (serdeandparse).I also made handling the case of
info.tomlnot existing in the current directory part of the error handling when trying to read the file. This eliminates a redundant syscall and the usage ofunwrap.