Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(errorsn.rs) Update the deprecated syntax by adding dyn to trait o… #212

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

sosnowski
Copy link
Contributor

fix(errorsn.rs) Update the deprecated syntax by adding dyn to trait objects.

closes #211

Related issue: #211

Copy link

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update line 193 to have a correct hint.

// on the error value to convert it to a boxed trait object, a Box<error::Error>,
// on the error value to convert it to a boxed trait object, a Box<dyn error::Error>,

@sosnowski
Copy link
Contributor Author

Good catch! I've updated the PR. Thanks

Copy link
Contributor

@komaeda komaeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@komaeda
Copy link
Contributor

komaeda commented Aug 21, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 21, 2019

📌 Commit 8109cba has been approved by komaeda

@bors
Copy link
Contributor

bors commented Aug 21, 2019

⌛ Testing commit 8109cba with merge f9987c8...

bors added a commit that referenced this pull request Aug 21, 2019
fix(errorsn.rs) Update the deprecated syntax by adding dyn to trait o…

fix(errorsn.rs) Update the deprecated syntax by adding dyn to trait objects.

closes #211

Related issue: #211
@bors
Copy link
Contributor

bors commented Aug 21, 2019

☀️ Test successful - checks-travis
Approved by: komaeda
Pushing f9987c8 to master...

@bors bors merged commit 8109cba into rust-lang:master Aug 21, 2019
pedantic79 pushed a commit to pedantic79/rustlings that referenced this pull request Apr 11, 2020
fix(errorsn.rs) Update the deprecated syntax by adding dyn to trait o…

fix(errorsn.rs) Update the deprecated syntax by adding dyn to trait objects.

closes rust-lang#211

Related issue: rust-lang#211
ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
fix(errorsn.rs) Update the deprecated syntax by adding dyn to trait o…

fix(errorsn.rs) Update the deprecated syntax by adding dyn to trait objects.

closes rust-lang#211

Related issue: rust-lang#211
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
fix(errorsn.rs) Update the deprecated syntax by adding dyn to trait o…

fix(errorsn.rs) Update the deprecated syntax by adding dyn to trait objects.

closes rust-lang#211

Related issue: rust-lang#211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error_handling/errorsn.rs uses deprecated Trait - related syntax
4 participants