Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(watch): clear screen before each verify() #228

Merged
merged 1 commit into from
Nov 9, 2019

Conversation

WofWca
Copy link
Contributor

@WofWca WofWca commented Nov 9, 2019

Closes #146
It seems to me that #227 wasn't really fixing the issue.

@shadows-withal
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 9, 2019

📌 Commit 3aff590 has been approved by fmoko

@bors
Copy link
Contributor

bors commented Nov 9, 2019

⌛ Testing commit 3aff590 with merge 3232a4d...

bors added a commit that referenced this pull request Nov 9, 2019
improvement(watch): clear screen before each `verify()`

Closes #146
It seems to me that #227 wasn't really fixing the issue.
@bors
Copy link
Contributor

bors commented Nov 9, 2019

☀️ Test successful - checks-travis
Approved by: fmoko
Pushing 3232a4d to master...

@bors bors merged commit 3aff590 into rust-lang:master Nov 9, 2019
@workingjubilee
Copy link
Contributor

Hmm, I suppose I was implementing a very conservative interpretation of "clear screen before watch", which was possibly splitting the difference between misunderstanding the request and general reluctance to implement a more radical change.

pedantic79 pushed a commit to pedantic79/rustlings that referenced this pull request Apr 11, 2020
improvement(watch): clear screen before each `verify()`

Closes rust-lang#146
It seems to me that rust-lang#227 wasn't really fixing the issue.
ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
improvement(watch): clear screen before each `verify()`

Closes rust-lang#146
It seems to me that rust-lang#227 wasn't really fixing the issue.
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
improvement(watch): clear screen before each `verify()`

Closes rust-lang#146
It seems to me that rust-lang#227 wasn't really fixing the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustlings watch Should clear the shell.
4 participants