Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document installing to a custom location using CARGO_HOME and RUSTUP_HOME environment variables #1024

Merged

Conversation

sjmarshy
Copy link
Contributor

@sjmarshy sjmarshy commented Apr 1, 2017

This should Fix #994

Add a section Choosing where to install to the install section of the README discussing the
use of CARGO_HOME and RUSTUP_HOME

including the CARGO_HOME and RUSTUP_HOME environment variables
README.md Outdated
#### Choosing where to install

`rustup` allows you to customise your installation by setting the environment
variables `CARGO_HOME` and `RUSTUP_HOME` while running the `rustup-init`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think saying "while" might give the wrong impression, despite the clarification below. Maybe say "before running" instead?

@Diggsey
Copy link
Contributor

Diggsey commented Apr 1, 2017

LGTM with that one change

@Diggsey
Copy link
Contributor

Diggsey commented Apr 1, 2017

@bors r+ Thanks!

@bors
Copy link
Contributor

bors commented Apr 1, 2017

📌 Commit 205608c has been approved by Diggsey

@bors
Copy link
Contributor

bors commented Apr 2, 2017

⌛ Testing commit 205608c with merge 33e6b1f...

bors added a commit that referenced this pull request Apr 2, 2017
…=Diggsey

Document installing to a custom location using CARGO_HOME and RUSTUP_HOME environment variables

This should Fix #994

Add a section `Choosing where to install` to the `install` section of the README discussing the
use of `CARGO_HOME` and `RUSTUP_HOME`
@bors
Copy link
Contributor

bors commented Apr 2, 2017

💔 Test failed - status-appveyor

@Diggsey Diggsey merged commit 705c110 into rust-lang:master Apr 2, 2017
@sjmarshy sjmarshy deleted the document-cargo-home-and-rustup-home branch April 2, 2017 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants