Increase Rust detection timeout to 3 seconds #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! The second part of solving #1118 is to provide a different error message for when the timeout occurs, vs when the command fails - would you be able to update the PR to include that change too? Then the issue can be closed out. |
|
No problem, I'll do it later today. |
|
Cold start, damaged nightly Should I squash commits? |
|
No, that's fine, thanks! |
|
📌 Commit b8a0dda has been approved by |
bors
added a commit
that referenced
this pull request
May 22, 2017
Increase Rust detection timeout to 3 seconds Fixes #1118 With 3 seconds timeout cold start isn't issue anymore. To simulate cold start use: ``` sync ; echo 3 | sudo tee /proc/sys/vm/drop_caches rustup update ```
|
💔 Test failed - status-travis |
|
@bors retry |
bors
added a commit
that referenced
this pull request
May 22, 2017
Increase Rust detection timeout to 3 seconds Fixes #1118 With 3 seconds timeout cold start isn't issue anymore. To simulate cold start use: ``` sync ; echo 3 | sudo tee /proc/sys/vm/drop_caches rustup update ```
|
💔 Test failed - status-appveyor |
|
@bors retry |
bors
added a commit
that referenced
this pull request
May 22, 2017
Increase Rust detection timeout to 3 seconds Fixes #1118 With 3 seconds timeout cold start isn't issue anymore. To simulate cold start use: ``` sync ; echo 3 | sudo tee /proc/sys/vm/drop_caches rustup update ```
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1118
With 3 seconds timeout cold start isn't issue anymore.
To simulate cold start use: