Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell completions for Cargo #1646

Merged
merged 13 commits into from
Apr 14, 2019
Merged

Commits on Mar 16, 2019

  1. Configuration menu
    Copy the full SHA
    8371c20 View commit details
    Browse the repository at this point in the history
  2. Include shell completion for Cargo

    ricvelozo authored and yodaldevoid committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    147f46d View commit details
    Browse the repository at this point in the history
  3. Update the README

    ricvelozo authored and yodaldevoid committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    50c0f3e View commit details
    Browse the repository at this point in the history
  4. Move completion command handler to separate function

    Signed-off-by: Gabriel Smith <ga29smith@gmail.com>
    yodaldevoid committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    4ab5ff2 View commit details
    Browse the repository at this point in the history
  5. Add optional "command" argument to rustup completion

    This "command" argument allows rustup to output the completion information of
    more than just rustup. In this case it adds a cargo completion script.
    
    Signed-off-by: Gabriel Smith <ga29smith@gmail.com>
    yodaldevoid committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    e8ade2c View commit details
    Browse the repository at this point in the history
  6. For cargo completion script, output line to source real script

    This allows the cargo script for the current default toolchain to be called,
    and if the script is ever updated the user won't have to maually update their
    completion script after updating Rust.
    
    Signed-off-by: Gabriel Smith <ga29smith@gmail.com>
    yodaldevoid committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    634eba5 View commit details
    Browse the repository at this point in the history
  7. Add information to the help output about bash completions

    Signed-off-by: Gabriel Smith <ga29smith@gmail.com>
    yodaldevoid committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    dc6baeb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    af17f18 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4a4b260 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. Hold all programs with completions in an array

    This removes the duplication between the `variants` and `from_str`
    implementations.
    yodaldevoid committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    02d63fc View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2019

  1. cli: Rework completion error handling

    Moves the error reporting from the completion function to the standard
    error handling mechanism.
    
    CompletionCommand had to be made fully public, not that this matters for
    a binary target. That said, this could have been prevented by
    transforming the CompletionCommand into its String form at the error
    site rather than at the reporting site. It was chosen to go with this
    method as stringly-typed interfaces are generally bad.
    yodaldevoid committed Mar 30, 2019
    Configuration menu
    Copy the full SHA
    8a189fa View commit details
    Browse the repository at this point in the history
  2. test: mock: Add expect_ok_eq function

    Compares two different command invocations and panics if their return
    code and stdout/stderr don't match.
    yodaldevoid committed Mar 30, 2019
    Configuration menu
    Copy the full SHA
    9bb56d0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0312b11 View commit details
    Browse the repository at this point in the history