Add clippy-driver as a proxy
#1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Manishearth Should we be changing |
|
No, keep cargo-clippy exactly the same for now. Implementing this will be a long process and we'll need both to be around for a significant amount of time. We'll make a PR removing cargo-clippy when we need to 😄 thanks! |
Manishearth
approved these changes
Mar 4, 2019
|
Fixes #1678? |
Rats, you're quite right, I forgot that, I'll pop a fix up for that now. |
The Cargo team are taking `cargo clippy` on-board and as such will need `clippy-driver` as a general proxy. Fixes: rust-lang#1678 Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
kinnison
force-pushed
the
kinnison/cargo-clippy
branch
from
030d853
to
84f3dc8
Compare
|
Oops :D I think that'll be good to merge once green. |
|
it's green r? @dwijnand |
dwijnand
approved these changes
Mar 5, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cargo team are taking
cargo clippyon-board and as suchwill need
clippy-driveras a general proxy.Signed-off-by: Daniel Silverstone dsilvers@digital-scurf.org