Kinnison/fix progress on windows #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rust-lang#1781, we switched to using `delete_line()` but unfortunately that turns out to not work very well on Windows. So this commit turns us back to using spaces to erase things, but in a way which ought to be moderately more robust than before. There's still no guarantee we're doing it right, but at least this time if the terminal is approximately wide enough for the bar and no more, we won't be flowing onto the next line with loads of spaces after the rest of the tracker. Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
The amended erase was insufficient, this revert of term to 0.5.1 was also required otherwise the end-of-line was oddly miscoloured. Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
|
Tested and working on Windows 10 with both Powershell and CMD. |
|
Awesome, thank you @Skynoodle |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from testing the 1.18.0 RC on Windows, this is needed to fix line erase