Switch to std::fs::read_to_string #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinnison
approved these changes
Jun 21, 2019
|
I think the test failures are windows being odd. But I'd like @rbtcollins to confirm before merging. |
tesuji
force-pushed
the
fs-read-to-string
branch
from
b73d4b3
to
3c4a6d3
Compare
tesuji
changed the title
tesuji
force-pushed
the
fs-read-to-string
branch
from
3c4a6d3
to
0724f2d
Compare
|
The CI failures I haven't investigated, but I see no platform interactions to be concerned about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the doc: it is generally faster than reading into a string created with
String::new().