Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to std::fs::read_to_string #1906

Merged
merged 1 commit into from Jun 24, 2019

Conversation

Projects
None yet
3 participants
@lzutao
Copy link
Contributor

commented Jun 21, 2019

According to the doc: it is generally faster than reading into a string created with String::new().

@kinnison
Copy link
Collaborator

left a comment

While I question the wisdom of needing to improve performance on any of these pathways, I do agree that it simplifies the codebase by removing two implementations of what is essentially something from std

@kinnison

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2019

I think the test failures are windows being odd. But I'd like @rbtcollins to confirm before merging.

@lzutao lzutao force-pushed the lzutao:fs-read-to-string branch from b73d4b3 to 3c4a6d3 Jun 21, 2019

@lzutao lzutao changed the title Switch to the std::fs::read_to_string Switch to std::fs::read_to_string Jun 21, 2019

@lzutao lzutao force-pushed the lzutao:fs-read-to-string branch from 3c4a6d3 to 0724f2d Jun 21, 2019

@rbtcollins
Copy link
Collaborator

left a comment

LGTM

@rbtcollins

This comment has been minimized.

Copy link
Collaborator

commented Jun 24, 2019

The CI failures I haven't investigated, but I see no platform interactions to be concerned about.

@kinnison kinnison merged commit 4514881 into rust-lang:master Jun 24, 2019

0 of 2 checks passed

Travis CI - Pull Request Build Failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details

@lzutao lzutao deleted the lzutao:fs-read-to-string branch Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.