-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update futures/hyper crate to prepare async/.await #2112
Conversation
Hi @saneyuki Thank you for wanting to enhance |
Ah, okay. |
I look forward to seeing this evolve into a more complete solution over the coming weeks, so please don't be disheartened :D If you need help with any of the extra work, please pop onto our Discord channel on the Rust discord server and we can discuss things. |
As hyper v0.13 has been published, I added changes to switch to it. After working to switch to hyper v0.13, I felt wee don't have to wait async/.await support by reqwest by following reasons.
So I'd like to request to merge this without waiting reqwest's next version to make this pull request small changesets and I also think we should do work for request separately. |
This code looks much nicer than the old code, 👍 Could you please tidy/squash the series into two commits, one which changes all the source and Cargo.toml, and one which is just the result of the change to That way I can more easily confirm that the Cargo.lock update is safe. I agree that this is good to merge, content-wise, once that's done. |
Okay! I pushed squashed commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Let's just wait on the CI to confirm the squash was good.
CI is passed 😄 |
Ideally, we can replace futures with 0.3, but there are some limitation by the current ecosystem.
hyper v0.12 depends on future v0.1 and
hyper::server::Server
implements its traits.So we need to introduce futures01 crate as a cushion to migrate it.