Skip to content

/rustup.rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain ErrorKind::HttpStatus(404) to Download404 #515

Merged
merged 1 commit into from Jun 7, 2016
+12 −16

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cuviper @alexcrichton @brson
@cuviper
Copy link
Member

cuviper commented Jun 4, 2016

Rust pre-1.8.0 didn't have any manifests, so this leads to status 404.
Only error CURLE_FILE_COULDNT_READ_FILE was mapping to Download404
though, so a "successful" status 404 was causing rustup to give up on
old versions entirely. Now status 404 is mapped correctly too, and the
manifest fallbacks work correctly.

Fixes #487.
Fixes #502.
@cuviper
Chain ErrorKind::HttpStatus(404) to Download404 
Rust pre-1.8.0 didn't have any manifests, so this leads to status 404.
Only error `CURLE_FILE_COULDNT_READ_FILE` was mapping to `Download404`
though, so a "successful" status 404 was causing rustup to give up on
old versions entirely.  Now status 404 is mapped correctly too, and the
manifest fallbacks work correctly.

Fixes #487.
Fixes #502.
Loading status checks…
b2b9ac8
@cuviper

This comment has been minimized.

Sign in to view
Copy link
Member Author

cuviper commented Jun 4, 2016

I manually tested that I could install nightly-2016-02-11 per #487 and all the way from 1.7.0 to 1.0.0 for #502. It wasn't clear to me how to add mocked test cases for these though. I'd appreciate guidance.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jun 5, 2016

Oh dear sorry about that! Looks good to me!

@brson brson merged commit 8d1633f into rust-lang:master Jun 7, 2016
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jun 7, 2016

So awesome. Thanks!
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jun 7, 2016

I'm surprised this wasn't represented in the test suite....

@brson brson referenced this pull request Jun 7, 2016

Open

Add test for fallback to crate-based installation of specific revisions #517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.