Chain ErrorKind::HttpStatus(404) to Download404 #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust pre-1.8.0 didn't have any manifests, so this leads to status 404. Only error `CURLE_FILE_COULDNT_READ_FILE` was mapping to `Download404` though, so a "successful" status 404 was causing rustup to give up on old versions entirely. Now status 404 is mapped correctly too, and the manifest fallbacks work correctly. Fixes rust-lang#487. Fixes rust-lang#502.
|
Oh dear sorry about that! Looks good to me! |
|
So awesome. Thanks! |
|
I'm surprised this wasn't represented in the test suite.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust pre-1.8.0 didn't have any manifests, so this leads to status 404.
Only error
CURLE_FILE_COULDNT_READ_FILEwas mapping toDownload404though, so a "successful" status 404 was causing rustup to give up on
old versions entirely. Now status 404 is mapped correctly too, and the
manifest fallbacks work correctly.
Fixes #487.
Fixes #502.