Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download progress indicator doesn't show up. Needs term >= 0.5.0 ? #1364

Closed
ynakao opened this issue Mar 2, 2018 · 7 comments
Closed

Download progress indicator doesn't show up. Needs term >= 0.5.0 ? #1364

ynakao opened this issue Mar 2, 2018 · 7 comments
Labels

Comments

@ynakao
Copy link
Contributor

ynakao commented Mar 2, 2018

Today I noticed when upgrading Rust v1.24.1, download progress indicators didn't appear at my Arch linux PC.

noeta

At macOS machine, download ETA showed up properly.

rustup

This function is handled by download_tracker.rs, and to write the info on the terminal term crate is necessary. So, I searched at term crate issues, found the one which seems to cause this problem. According to the discussion, if installed ncurses version is above v6.1 this happens, and they released fixed term v0.5.0.

My Arch has ncurses v6.1, and I tested other machines. In Debian stable which has v6.0 download indicator worked, but Debian testing which has v6.1 it didn't work (ncurses-bin). macOS may have v5.x since there's /usr/bin/ncurses5.4-config.

Also I tried cloning this repo and build rustup localy with the change term = "0.5" in Cargo.toml (currently term = "0.4.4") at my Arch machine. In the result, rustup worked fine displaying ETA messages.

afterbuild

Therefore, I think it needs to change rustup dependency information especially term crate version number. I'm sorry if I'm wrong.

@ynakao ynakao changed the title Download progress indicator doesn't show up. Needs term >= 5.0 ? Download progress indicator doesn't show up. Needs term >= 0.5.0 ? Mar 2, 2018
@Frederick888
Copy link

Same here. Arch Linux + Yakuake + Zsh.

@killkrt
Copy link

killkrt commented May 5, 2018

Same here. Progress is not shown anymore on Linux, while is working perfectly on macOS and Windows.

OS: Arch Linux (kernel 4.16.6-1)
Shell: Zsh 5.5.1

@Diggsey
Copy link
Contributor

Diggsey commented May 28, 2018

A PR for this would be welcome

@ynakao
Copy link
Contributor Author

ynakao commented May 28, 2018

I just submitted PR #1422.

@Diggsey Diggsey moved this from Downloads to Fixed, pending release ⏳ in Issue Categorisation May 28, 2018
@Diggsey Diggsey removed this from Fixed, pending release ⏳ in Issue Categorisation Jul 8, 2018
@milahu
Copy link

milahu commented Dec 15, 2020

still have the same problem: download starts, but progress is not visible

rustup --version
rustup 1.22.1 (2020-07-08)

uname -r
5.9.9-arch1-1

which $0
/usr/bin/bash

ldd /usr/bin/bash | grep curses
	libncursesw.so.6 => /usr/lib/libncursesw.so.6 (0x00007f3075c49000)

rustup default 1.46.0-x86_64-unknown-linux-gnu
info: using existing install for '1.45.0-x86_64-unknown-linux-gnu'
info: default toolchain set to '1.45.0-x86_64-unknown-linux-gnu'

  1.45.0-x86_64-unknown-linux-gnu unchanged - rustc 1.45.0 (5c1f21c3b 2020-07-13)

rustup target add wasm32-unknown-emscripten
info: downloading component 'rust-std' for 'wasm32-unknown-emscripten'
^C

rustup --verbose target add wasm32-unknown-emscripten
verbose: read metadata version: '12'
info: downloading component 'rust-std' for 'wasm32-unknown-emscripten'
verbose: downloading file from: 'https://static.rust-lang.org/dist/2020-07-16/rust-std-1.45.0-wasm32-unknown-emscripten.tar.xz'
verbose: downloading with reqwest
verbose: resuming partial download
^C

@kinnison
Copy link
Contributor

Sadly we're stuck on an older term until/unless we can replace it with something else entirely. Term 0.5 broke Windows. We have other issues open for finding a replacement.

@milahu
Copy link

milahu commented Dec 15, 2020

aah, thanks .. #1818 #1835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants