Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when tools are missing and allow to override #1337

Merged
merged 3 commits into from
Jan 16, 2018

Commits on Jan 11, 2018

  1. Catch some missing components that weren't warned on

    There is a lot of refactoring here too.
    
    There was a check to ensure that if there are components that we plan to install (or update) that are missing from the manifest, then we error out. However, this only worked for components that had an entry in the manifest under the Rust package, but were missing components of their own. For tools like the RLS, when they are missing, they are completely missing from the manifest. They therefore didn't get picked up by the check. This patch adds an extra Vec to track such components and then warns about them.
    nrc committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    6ab0843 View commit details
    Browse the repository at this point in the history
  2. Support --force for rustup update

    nrc committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    5544880 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2018

  1. tests

    This adds a new test and removes test `update_removes_components_that_dont_exist`
    
    Historically, this test was added before the check that aborts update on missing
    components (which is tested by the new test in the previous commit, as well as
    elsewhere), so I think this test was only testing a bug.
    
    Note that the new behaviour is the same as the ancient behviour when the user
    uses `--force`
    nrc committed Jan 14, 2018
    Configuration menu
    Copy the full SHA
    dcf0f9d View commit details
    Browse the repository at this point in the history